Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the jupyter labextension list compat message #14680

Merged
merged 1 commit into from Jun 14, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 14, 2023

References

Currently running jupyter labextension list will suggest using the jupyter labextension update --all command to update extensions when it finds compatibility issues:

   The following extensions are outdated:
        jupyterlab_pygments
        @jupyter-widgets/jupyterlab-manager
        @voila-dashboards/jupyterlab-preview

   Consider running "jupyter labextension update --all" to check for updates.

However the jupyter labextension update command is now deprecated and will be removed in the future:

Code changes

Update the message printed in the terminal to not suggest using this command.

User-facing changes

Users listing extensions should not see jupyter labextension update --all anymore.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio changed the title Update the compat message when running jupyter labextension list Update the jupyter labextension list compat message Jun 14, 2023
@jtpio
Copy link
Member Author

jtpio commented Jun 14, 2023

We might want to backport this to 3.6.x as well.

@jtpio jtpio added this to the 3.6.x milestone Jun 14, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio

@jtpio jtpio merged commit 2715840 into jupyterlab:main Jun 14, 2023
79 of 83 checks passed
@jtpio jtpio deleted the update-compat-message branch June 14, 2023 17:00
@jtpio
Copy link
Member Author

jtpio commented Jun 14, 2023

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 14, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2715840f904373642a05dc8126a9d8fa0fa91467
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14680: Update the `jupyter labextension list` compat message'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-14680-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #14680 on branch 3.6.x (Update the jupyter labextension list compat message)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Jul 18, 2023
fcollonval added a commit that referenced this pull request Jul 19, 2023
…sage (#14844)

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants