Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archived repos from the post release checklist #14259

Merged
merged 1 commit into from Mar 22, 2023
Merged

Remove archived repos from the post release checklist #14259

merged 1 commit into from Mar 22, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 22, 2023

References

Minor edits to the Post release candidate checklist section of RELEASE.md: https://github.com/jupyterlab/jupyterlab/blob/master/RELEASE.md#post-release-candidate-checklist

Code changes

Update the release docs to remove the archived repos from the list.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0.0 milestone Mar 22, 2023
fcollonval
fcollonval approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 481 <- [544 - 572 - 621] -> 732 1047 <- [1115 - 1141 - 1167] -> 1329
expected 482 <- [545 - 565 - 583] -> 1080 699 <- [1106 - 1139 - 1165] -> 1272
Mean relative change 2.4% ± 2.9% 1.3% ± 1.5%
switch-from
chromium
actual 526 <- [621 - 639 - 652] -> 816 267 <- [330 - 350 - 376] -> 445
expected 544 <- [616 - 630 - 646] -> 944 269 <- [324 - 352 - 381] -> 451
Mean relative change 1.1% ± 1.8% -0.0% ± 3.1%
switch-to
chromium
actual 1034 <- [1071 - 1087 - 1113] -> 1265 696 <- [735 - 754 - 768] -> 807
expected 990 <- [1069 - 1082 - 1109] -> 1486 709 <- [741 - 759 - 772] -> 816
Mean relative change 0.2% ± 1.4% -0.3% ± 0.9%
close
chromium
actual 125 <- [143 - 150 - 156] -> 179 172 <- [193 - 197 - 203] -> 279
expected 130 <- [143 - 148 - 153] -> 191 166 <- [193 - 198 - 207] -> 232
Mean relative change 1.4% ± 1.7% -0.4% ± 1.7%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: -163 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentDeleted 1 +16 B
ContentString 1 +66 B
Detached Text 1 +71 B
FocusTracker 1 +276 B
ObservableList 1 +172 B
OutputArea 1 +1.43 kB
OutputAreaModel 1 +183 B
Promise 1 +24 B
PromiseDelegate 1 +128 B
ResizeHandle 1 +47 B
RestorablePool 1 +558 B
UndoManager 1 +1.93 kB
WidgetTracker 1 +1.05 kB
YArray 1 +164 B
YCodeCell 1 +107 B
YText 1 +40 B
Detached DOMStringMap 2 +92 B
Detached V8EventHandlerNonNull 2 +80 B
Set 2 +1.42 kB
YMap 2 +464 B
StackItem 3 +1.32 kB
ContentAny 4 +235 B
ContentType 4 +64 B
DeleteItem 4 +80 B
DeleteSet 6 +988 B
Detached HTMLCollection 6 +564 B
EventHandler 8 +250 B
ID 10 +320 B
Item 10 +1.2 kB
Detached DOMTokenList 13 +836 B
Detached Attr 14 +1.01 kB
Detached HTMLDivElement 14 +46.7 kB
Map 17 +11 kB
Signal 19 +319 B
Array 44 +25.3 kB
Detached V8EventListener 263 +23.4 kB
Detached EventListener 265 +42.6 kB
(closure) 270 +6.54 kB
Detached InternalNode 323 +45.1 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +1 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a markdown cell Memory change: -106 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +294 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +193 B
AttachmentsResolver 1 +14 B
CodeCellModel 1 +359 B
ContentString 1 +69 B
Debouncer 1 +3.46 kB
Detached HTMLAnchorElement 1 +312 B
Detached HTMLButtonElement 1 +5.32 kB
Detached HTMLHeadingElement 1 +1.01 kB
Error 1 +3.06 kB
MarkdownCell 1 +4.73 kB
MarkdownCellModel 1 +237 B
Poll 1 +3.7 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +66 B
Transaction 1 +860 B
TypeError 1 +295 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YCodeCell 1 +107 B
YMarkdownCell 1 +45 B
Detached CSSStyleDeclaration 2 +124 B
Detached HTMLElement 2 +320 B
Detached V8EventHandlerNonNull 2 +5.04 kB
Promise 2 +3.06 kB
PromiseDelegate 2 +3.27 kB
UndoManager 2 +2.38 kB
YText 2 +479 B
Detached DOMStringMap 3 +128 B
ObservableMap 3 +381 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +490 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached Text 7 +504 B
Set 8 +1.76 kB
Detached HTMLDivElement 10 +30.5 kB
Detached DOMTokenList 13 +828 B
ID 13 +416 B
Item 13 +1.75 kB
EventHandler 14 +448 B
Detached HTMLCollection 17 +1.8 kB
Map 27 +12.1 kB
Signal 28 +722 B
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.5 kB
(closure) 152 +20.2 kB
Detached InternalNode 162 +28.3 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [df3de2ad-e925-4cf6-8c83-aa9a1cdd6b35, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a raw cell Memory change: -182 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
CodeCellModel 1 +177 B
ContentString 1 +690 B
Detached CSSStyleDeclaration 1 +60 B
Detached V8EventHandlerNonNull 1 +40 B
ObservableMap 1 +109 B
TypeError 1 +301 B
YArray 1 +164 B
YCodeCell 1 +-61 B
YRawCell 1 +45 B
Detached DOMStringMap 2 +92 B
Set 2 +1.33 kB
UndoManager 2 +2.38 kB
YText 2 +1.24 kB
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +524 B
Detached HTMLCollection 5 +468 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached DOMTokenList 9 +568 B
Detached HTMLDivElement 9 +22.5 kB
Signal 11 +322 B
ID 13 +416 B
Item 13 +2.41 kB
EventHandler 14 +425 B
Map 19 +11.3 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 140 +-4.32 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [9c975e2b-b924-482a-a185-d4a8ea802d6f, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22                                                                                  
- Drag and drop a cell

File editor memory leaks

Create a file Memory change: -75.9 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.3 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.7 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +124 B
LabIcon 2 +1.07 kB
Detached CSSStyleDeclaration 3 +208 B
Detached HTMLLIElement 3 +5.16 kB
Detached NodeList 3 +180 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +110 B
Detached SVGGElement 4 +2.94 kB
VirtualElement 4 +2.2 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.77 kB
Detached SVGSVGElement 5 +7.9 kB
Detached HTMLSpanElement 6 +2.26 kB
Detached DOMStringMap 7 +348 B
Detached SVGAnimatedNumber 7 +448 B
Detached Attr 10 +720 B
Detached Text 10 +708 B
Detached HTMLCollection 13 +1.41 kB
Detached DOMTokenList 14 +896 B
Detached HTMLDivElement 15 +32.5 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Array 42 +24.7 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +26 kB
✔ Opening a text file (65823ms)

Notebook memory leaks

Create a notebook Memory change: +27.3 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.3 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +55 B
Detached HTMLButtonElement 2 +23.4 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +91 B
LabIcon 2 +99 B
Detached CSSStyleDeclaration 3 +252 B
Detached HTMLLIElement 3 +6.05 kB
Detached NodeList 3 +240 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +107 B
VirtualElement 4 +-26 B
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.28 kB
Detached HTMLSpanElement 6 +3.06 kB
Detached SVGGElement 6 +4.9 kB
Detached SVGPathElement 7 +2.47 kB
Detached SVGAnimatedNumber 9 +576 B
Detached Attr 10 +720 B
Detached Text 10 +716 B
Detached HTMLCollection 13 +1.32 kB
Detached DOMTokenList 15 +960 B
Detached HTMLDivElement 15 +33.2 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
Array 21 +22.9 kB
Detached SVGAnimatedLength 26 +1.66 kB
Object 59 +196 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +43.2 kB

1 passing (6m)
1 pending
2 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1322
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)


   Opening a notebook:

  Create a notebook - Objects leaking
  + expected - actual

  -681
  +672
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/notebook.test.mjs:6:5)

@jtpio jtpio merged commit a3a0e3e into jupyterlab:master Mar 22, 2023
75 of 78 checks passed
@jtpio jtpio deleted the release-checklist branch March 22, 2023 16:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
documentation
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @fcollonval