Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude .yarn cache from the dist #14242

Merged
merged 2 commits into from Mar 21, 2023
Merged

Exclude .yarn cache from the dist #14242

merged 2 commits into from Mar 21, 2023

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Mar 21, 2023 •
edited

References

Fixes #14241

The last release of JupyterLab is 90Mb! https://pypi.org/project/jupyterlab/4.0.0a37/#files

This PR fixes it by removing the .yarn cache from the sdist and the wheel

Kudos to @trungleduc for spotting it

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added this to the 4.0.0 milestone Mar 21, 2023
@martinRenou martinRenou changed the title Exclude .yarn cache and tests from the dist Exclude .yarn cache from the dist Mar 21, 2023
@martinRenou
Copy link
Member Author

I wanted to also exclude tests but it seems that jupyterlab.browser_checks uses this module, so my PR now only removes the .yarn folder.

I can confirm that the wheel is now 9.2Mb.

@jtpio
Copy link
Member

jtpio commented Mar 21, 2023

Thanks!

Looks like the assets (built by the releaser) are back to a reasonable size (similar to 4.0.0a36):

image

jtpio
jtpio approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 72822a0 into jupyterlab:master Mar 21, 2023
74 of 77 checks passed
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 508 <- [570 - 590 - 641] -> 715 603 <- [1207 - 1231 - 1273] -> 1378
expected 507 <- [553 - 575 - 602] -> 856 1093 <- [1183 - 1224 - 1256] -> 1350
Mean relative change 2.1% ± 2.5% 1.4% ± 1.6%
switch-from
chromium
actual 536 <- [647 - 667 - 683] -> 741 304 <- [352 - 378 - 402] -> 452
expected 572 <- [635 - 656 - 674] -> 854 295 <- [350 - 380 - 401] -> 479
Mean relative change 0.6% ± 1.8% 0.7% ± 2.8%
switch-to
chromium
actual 1134 <- [1184 - 1211 - 1248] -> 1380 760 <- [827 - 844 - 864] -> 972
expected 1122 <- [1167 - 1184 - 1218] -> 1403 772 <- [815 - 833 - 855] -> 934
Mean relative change 1.9% ± 1.4% 1.3% ± 1.2%
close
chromium
actual 135 <- [150 - 156 - 160] -> 181 198 <- [208 - 213 - 225] -> 277
expected 134 <- [147 - 152 - 156] -> 185 195 <- [207 - 214 - 227] -> 313
Mean relative change 2.1% ± 1.6% -0.1% ± 2.3%

Changes are computed with expected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cell Memory change: +155 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
ContentDeleted 1 +16 B
ContentString 1 +74 B
Detached Text 1 +68 B
FocusTracker 1 +276 B
ObservableList 1 +60 B
OutputArea 1 +1.4 kB
OutputAreaModel 1 +115 B
Promise 1 +20 B
PromiseDelegate 1 +128 B
ResizeHandle 1 +47 B
RestorablePool 1 +304 B
UndoManager 1 +1.93 kB
WidgetTracker 1 +976 B
YArray 1 +164 B
YCodeCell 1 +107 B
YText 1 +46 B
Detached DOMStringMap 2 +88 B
Detached V8EventHandlerNonNull 2 +80 B
Set 2 +1.21 kB
YMap 2 +464 B
StackItem 3 +1.32 kB
ContentAny 4 +241 B
ContentType 4 +64 B
DeleteItem 4 +80 B
DeleteSet 6 +988 B
Detached HTMLCollection 6 +548 B
EventHandler 8 +256 B
ID 10 +320 B
Item 10 +1.21 kB
Detached DOMTokenList 13 +812 B
Detached Attr 14 +1.01 kB
Detached HTMLDivElement 14 +46.7 kB
Map 17 +2.63 kB
Signal 19 +319 B
DOMRectReadOnly 32 +1.79 kB
Array 44 +5.59 kB
Detached V8EventListener 263 +23.4 kB
Detached EventListener 265 +42.6 kB
(closure) 270 +26.4 kB
Detached InternalNode 323 +45.1 kB

Leaking collections:

Type Change Preview Size increased at
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +10 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +1 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a markdown cell Memory change: -148 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
ActivityMonitor 1 +294 B
ArraySearchMarker 1 +5 B
AttachmentsModel 1 +193 B
AttachmentsResolver 1 +14 B
CodeCellModel 1 +177 B
ContentString 1 +69 B
Debouncer 1 +3.46 kB
Detached HTMLAnchorElement 1 +300 B
Detached HTMLButtonElement 1 +5.3 kB
Detached HTMLHeadingElement 1 +960 B
Error 1 +3.06 kB
MarkdownCell 1 +4.73 kB
MarkdownCellModel 1 +237 B
Poll 1 +3.7 kB
RenderMimeRegistry 1 +227 B
RenderedMarkdown 1 +66 B
Transaction 1 +860 B
TypeError 1 +312 B
YArray 1 +164 B
YArrayEvent 1 +357 B
YCodeCell 1 +107 B
YMarkdownCell 1 +45 B
Detached CSSStyleDeclaration 2 +136 B
Detached HTMLElement 2 +304 B
Detached V8EventHandlerNonNull 2 +5.04 kB
Promise 2 +3.06 kB
PromiseDelegate 2 +3.27 kB
UndoManager 2 +2.38 kB
YText 2 +473 B
Detached DOMStringMap 3 +156 B
ObservableMap 3 +381 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +490 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached Text 7 +476 B
Set 8 +1.79 kB
Detached HTMLDivElement 10 +30.6 kB
Detached DOMTokenList 13 +872 B
ID 13 +416 B
Item 13 +1.75 kB
EventHandler 14 +442 B
Detached HTMLCollection 17 +1.8 kB
Map 27 +12.1 kB
Signal 28 +594 B
Array 74 +29 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 132 +25.5 kB
(closure) 152 +-12.2 kB
Detached InternalNode 162 +28.4 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [51c02832-3d6f-4db8-9dd8-9e665e6385b0, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a raw cell Memory change: +141 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
ArraySearchMarker 1 +5 B
CodeCellModel 1 +400 B
ContentString 1 +690 B
Detached CSSStyleDeclaration 1 +72 B
Detached V8EventHandlerNonNull 1 +40 B
ObservableMap 1 +102 B
TypeError 1 +306 B
YArray 1 +164 B
YCodeCell 1 +107 B
YRawCell 1 +45 B
Detached DOMStringMap 2 +104 B
Set 2 +1.26 kB
UndoManager 2 +2.38 kB
YText 2 +462 B
StackItem 3 +1.33 kB
DeleteItem 4 +80 B
YMap 4 +872 B
ContentAny 5 +454 B
Detached HTMLCollection 5 +488 B
DeleteSet 6 +1 kB
ContentType 7 +112 B
Detached DOMTokenList 9 +636 B
Detached HTMLDivElement 9 +22.7 kB
Signal 11 +484 B
ID 13 +416 B
Item 13 +2.34 kB
EventHandler 14 +431 B
Map 19 +2.77 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 140 +24.3 kB
Detached InternalNode 151 +21.7 kB

Leaking collections:

Type Change Preview Size increased at
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30               
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28              
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2719:15
Array +1 [ac9c670a-40af-4da9-8e8d-3ce5e5afd442, ...] 
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2503:37            
Array.forEach                        <anonymous>                                                               
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2498:21            
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12             
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2650:15     
CommandRegistry.execute              http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5748:33
CommandRegistry._executeKeyBinding   http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5906:14
CommandRegistry.processKeydownEvent  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:5846:18
JupyterLab.evtKeydown                http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:4660:23
Array +1 [{signal, slot, thisArg}, ...] 
Object.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10490:17
Signal.connect  http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33         
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Signal.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30                
invokeSlot      http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10699:18
Object.emit     http://localhost:8888/static/lab/jlab_core.6882a32e5e247c101f12.js:10657:17
Array +2 [StackItem, ...] 
UndoManager.afterTransactionHandler  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.forEach                        <anonymous>                                                                                           
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62                                            
Array.<anonymous>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0                                               
cleanupTransactions                  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transact                             http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9 
Doc.transact                         http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array +13 [Item, ...] 
addStruct                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integrate               http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>                                                                                           
typeListInsertGenericsAfter  http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenerics       http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9 
transact                     http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.insert                http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set +2 Set((anonymous function), ...) 
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56                                                                                     
Doc.on                    http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11                                         
new UndoManager           http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14                                         
YCodeCell.setUndoManager  http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33 
<unknown>                 http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>                                                                                                                                    
YNotebook.insertCells     http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCell      http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22                                                                                  
- Drag and drop a cell

File editor memory leaks

Create a file Memory change: -73.6 kB Leak detected: No

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +3.12 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +38 B
Detached HTMLButtonElement 2 +23.7 kB
Detached SVGCircleElement 2 +1.1 kB
LabIcon 2 +1.07 kB
Detached CSSStyleDeclaration 3 +228 B
Detached HTMLLIElement 3 +5.93 kB
Detached NodeList 3 +192 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +109 B
Detached SVGGElement 4 +2.94 kB
VirtualElement 4 +2.16 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGPathElement 5 +1.77 kB
Detached SVGSVGElement 5 +8.02 kB
Detached HTMLSpanElement 6 +2.32 kB
Detached DOMStringMap 7 +428 B
Detached SVGAnimatedNumber 7 +448 B
Detached Attr 10 +720 B
Detached Text 10 +916 B
Detached HTMLCollection 13 +1.42 kB
Detached DOMTokenList 14 +928 B
Detached HTMLDivElement 15 +33.4 kB
Detached SVGAnimatedString 16 +896 B
Detached SVGAnimatedTransformList 16 +1.02 kB
Detached SVGAnimatedLength 26 +1.66 kB
Array 42 +24.8 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +28.5 kB
✔ Opening a text file (65559ms)

Notebook memory leaks

Create a notebook Memory change: +25.9 kB Leak detected: Yes

Leaking objects:

Object # added Retained size increase
Detached HTMLUListElement 1 +2.21 kB
Detached V8EventHandlerNonNull 1 +40 B
VirtualElementPass 1 +46 B
Detached HTMLButtonElement 2 +23.4 kB
Detached SVGCircleElement 2 +1.1 kB
HTMLDivElement 2 +-5 B
LabIcon 2 +106 B
Detached CSSStyleDeclaration 3 +252 B
Detached HTMLLIElement 3 +5.96 kB
Detached NodeList 3 +240 B
NavigationHistoryEntry 3 +720 B
VirtualText 3 +108 B
VirtualElement 4 +1.15 kB
Detached SVGAnimatedPreserveAspectRatio 5 +320 B
Detached SVGAnimatedRect 5 +320 B
Detached SVGSVGElement 5 +9.29 kB
Detached HTMLSpanElement 6 +3.05 kB
Detached SVGGElement 6 +4.9 kB
Detached SVGPathElement 7 +2.47 kB
Detached SVGAnimatedNumber 9 +576 B
Detached Attr 10 +720 B
Detached Text 10 +700 B
Detached HTMLCollection 13 +1.33 kB
Detached DOMTokenList 15 +996 B
Detached HTMLDivElement 15 +33.2 kB
Detached SVGAnimatedString 20 +1.12 kB
Detached SVGAnimatedTransformList 20 +1.28 kB
Detached SVGAnimatedLength 26 +1.66 kB
Detached V8EventListener 130 +10.9 kB
Detached EventListener 131 +20.4 kB
(closure) 138 +37.4 kB
✔ Opening a notebook (69047ms)

2 passing (6m)
1 pending
1 failing

   Adding a cell:

  Create a code cell - Objects leaking
  + expected - actual

  -1354
  +1308
  
  at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16
  at Array.forEach (<anonymous>)
  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)
  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)
  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

@martinRenou martinRenou deleted the exclude_yarn_cache branch March 22, 2023 08:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@martinRenou martinRenou

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

jupyterlab 4.0.0a37 package is considerably bigger than jupyterlab 4.0.0a36
3 participants
@martinRenou @jtpio @krassowski