Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to jupyter_server_config.py #13208

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 10, 2022

References

Fixes #12897

Code changes

Updates the latest docs to mention jupyter_server_config,py instead of the deprecated jupyter_notebook_config.py.

User-facing changes

Documentation update.

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0.0 milestone Oct 10, 2022
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jtpio
Copy link
Member Author

jtpio commented Oct 10, 2022

One of the CI failures is being tracked in #13209

@fcollonval fcollonval merged commit e6f0393 into jupyterlab:master Oct 11, 2022
@jtpio jtpio deleted the update-docs branch October 11, 2022 07:35
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 9, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e6f0393aa118d76cc325f61b137708bee1fe18d3
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13208: Update docs to `jupyter_server_config.py`'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13208-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13208 on branch 3.6.x (Update docs to jupyter_server_config.py)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JupyterLab docs to remove references to jupyter_notebook_config
3 participants