-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoStartDefault
to getKernelPreference
#12793
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
@afshin @fcollonval Any updates? |
This would also alleviate a problem currently faced for users of krassowski/jupyterlab-voice-control#5 extension. I am tagging it as a @aditya211935 thank you for your contribution. Next time to get the PRs faster through the review please first open an issue describing the problem that you are trying to fix, as recommended and explained in the contributing guideline. |
Would you mind updating with the latest master branch (rebase or merge) so we can make sure the tests are passing? At the time of last commit there was something failing with the UI tests (unrelated to this PR). |
Thanks! It looks like the visual regression tests are failing and I believe that this is relevant to this change. This is because they await for a dialog window about kernel selection, which is being skipped with this PR. |
I think that |
@krassowski Sure, will add |
References
Code changes
getDefaultKernel
function requiresautoStartDefault
argument to returndefaultKernel
. This in turn is used to start the notebook with default kernel if no kernel is specified.However,
autoStartDefault
property is not defined anywhere execept in the original interface.jupyterlab/packages/apputils/src/sessioncontext.tsx
Line 274 in b57ec96
I've added
autoStartDefault
property toNotebookWidgetFactory
astrue
. This fixes the problem.User-facing changes
Previously, on clicking
New Notebook
from file explorer's context menu, the notebook would be opened without any kernel.With these changes, the notebook opens with the default kernel.
Screen.Recording.2022-07-12.at.12.59.09.AM.mov
Backwards-incompatible changes