Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the stale message to have an actual value. #10575

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Set the stale message to have an actual value. #10575

merged 1 commit into from
Jul 8, 2021

Conversation

jasongrout
Copy link
Contributor

References

Follow up from #10553

Code changes

According to DynamoDS/Dynamo@8ac994c#diff-8162bb3b3d4da55f30fcbb603b5d630b21b397777a6a42eff0e0fba30bc746a1R15, we need an actual value for the stale message to be skipped.

User-facing changes

Backwards-incompatible changes

@jasongrout jasongrout added this to the 3.1 milestone Jul 8, 2021
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

jtpio
jtpio approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's give it a try!

@jtpio jtpio merged commit c26b315 into jupyterlab:master Jul 8, 2021
@jasongrout
Copy link
Contributor Author

Progress! It actually tried to set the label, but had a permission error: https://github.com/jupyterlab/jupyterlab/runs/3024915966?check_suite_focus=true#step:2:770

Error: [#10038] Error when adding a label: Resource not accessible by integration

@jasongrout jasongrout mentioned this pull request Jul 9, 2021
Merged
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@jasongrout jasongrout

Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasongrout @jtpio