New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll margin to headings for better alignment #15703
Add scroll margin to headings for better alignment #15703
Conversation
Thanks for making a pull request to jupyterlab! |
This needs to be backported to 4.0.x but without the test case because we kept the old behaviour of scrolling to the bottom of the cell in the 4.0.x backport of #15386 (so the tests are not failing on 4.0.x but users who toggle the setting on scroll behaviour would still see buttons being cut-off). |
which solved a problem with background of disabled buttons
3bec044
to
91037a7
Compare
CI is so green again 💚 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, verified behavior in Chrome and Firefox ESR on macOS.
@meeseeksdev please backport to 4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
References
Fixes #15670
Code changes
Fixes a regression caught by visual tests in which after scrolling to a heading, the target heading was too close to the edge of the notebook (with no margin, and with the cell toolbar buttons cut off).
This regression was a result of a security-related PR fixing the ToC implementation, which meant that the fallback code path which was giving us extra padding was no longer used, see #15670 (comment) for details.
User-facing changes
The cell toolbar buttons are fully available after scrolling to a heading; the heading is easier to read as there is more margin.
Backwards-incompatible changes
None