Add scroll margin to headings for better alignment (#15703)

* Add scroll-margin-top to headings * Update Playwright Snapshots * Update two snapshots to reflect new ui-tookit version which solved a problem with background of disabled buttons --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jupyterlab · Jan 29, 2024 · 728c2b3 · 728c2b3
1 parent 558c60f
commit 728c2b3
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 0 deletions.
diff --git a/...enchmark/notebook.spec.ts-snapshots/large-md-notebook-ipynb-benchmark-linux.png b/...enchmark/notebook.spec.ts-snapshots/large-md-notebook-ipynb-benchmark-linux.png
diff --git a/...t/jupyterlab/notebook-toolbar.test.ts-snapshots/paste-cell-jupyterlab-linux.png b/...t/jupyterlab/notebook-toolbar.test.ts-snapshots/paste-cell-jupyterlab-linux.png
diff --git a/...toc-scrolling.test.ts-snapshots/scrolled-to-bottom-heading-jupyterlab-linux.png b/...toc-scrolling.test.ts-snapshots/scrolled-to-bottom-heading-jupyterlab-linux.png
diff --git a/packages/rendermime/style/base.css b/packages/rendermime/style/base.css
@@ -283,6 +283,7 @@
   font-style: normal;
   margin: var(--jp-content-heading-margin-top) 0
     var(--jp-content-heading-margin-bottom) 0;
+  scroll-margin-top: var(--jp-content-heading-margin-top);
 }
 
 .jp-RenderedHTMLCommon h1:first-child,
@@ -292,6 +293,7 @@
 .jp-RenderedHTMLCommon h5:first-child,
 .jp-RenderedHTMLCommon h6:first-child {
   margin-top: calc(0.5 * var(--jp-content-heading-margin-top));
+  scroll-margin-top: calc(0.5 * var(--jp-content-heading-margin-top));
 }
 
 .jp-RenderedHTMLCommon h1:last-child,