Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcut UI failing on filtering when empty command is given #15695

Merged
merged 1 commit into from Jan 26, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jan 25, 2024

References

Fixes #15687

Code changes

  • fix typing in ShortcutUI.tsx (use proper types instead of any)
  • correct a name of private method to follow underscore convention
  • fix the issue by guarding against incorrect access to second item of one-element array created by split() on an empty string

User-facing changes

  1. Filtering shortcuts works in Shortcuts UI even when an extension provides incorrect but technically allowed shortcut with empty command (see jupyterlab-vim).
  2. (Command label missing) placeholder is shown when a label for a command cannot be retrieved

image

Backwards-incompatible changes

None

@krassowski krassowski added the bug label Jan 25, 2024
@krassowski krassowski added this to the 4.0.x milestone Jan 25, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member Author

The single visual regression failure is unrelated (tracked in #15670)

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit cd268ce into jupyterlab:main Jan 26, 2024
79 of 81 checks passed
@jtpio
Copy link
Member

jtpio commented Jan 26, 2024

@meeseeksdev please backport to 4.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Jan 26, 2024
krassowski added a commit that referenced this pull request Jan 26, 2024
…ommand is given (#15701)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts settings page breaks on search
2 participants