Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty command #133

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Jan 29, 2024

The PR #100 which fixed #73 broke the filtering in JupyterLab shortcuts UI (jupyterlab/jupyterlab#15687). While this was addressed in JupyterLab (jupyterlab/jupyterlab#15695), the shortcut added by vim extension is currently not labelled as such and shows up at the top of the list:

image

This PR adds a dummy command for this action, so that it is better documented for the user and in the code, also fixing the problem with missing category (and for users of an older JupyterLab version):

image

Also fixes a typo in another command name.

@krassowski krassowski added the bug Something isn't working label Jan 29, 2024
Copy link

Binder 👈 Launch a Binder on branch krassowski/jupyterlab-vim/fix-empty-command

Copy link
Collaborator

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ianhi ianhi merged commit 7977c42 into jupyterlab-contrib:main Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shift+escape broken in latest Firefox and chrome
2 participants