Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4.0.0a37 #6777

Merged
merged 16 commits into from
Mar 20, 2023
Merged

Update to JupyterLab 4.0.0a37 #6777

merged 16 commits into from
Mar 20, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 17, 2023

Fixes #6752

Update to the latest JupyterLab 4.0 pre-release: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0a37

@jtpio jtpio added this to the 7.0 milestone Mar 17, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/update-lab-4a37

@jtpio
Copy link
Member Author

jtpio commented Mar 20, 2023

So it looks like the checksum for locally linked files (referenced from the metapackage) changes easily.

For example in the check release run: https://github.com/jupyter/notebook/actions/runs/4465670269/jobs/7842958931?pr=6777

 "@jupyter-notebook/ui-components@file:../ui-components::locator=%40jupyter-notebook%2Fmetapackage%40workspace%3Apackages%2F_metapackage":
   version: 7.0.0-alpha.16
-  resolution: "@jupyter-notebook/ui-components@file:../ui-components#../ui-components::hash=ce4f18&locator=%40jupyter-notebook%2Fmetapackage%40workspace%3Apackages%2F_metapackage"
+  resolution: "@jupyter-notebook/ui-components@file:../ui-components#../ui-components::hash=284135&locator=%40jupyter-notebook%2Fmetapackage%40workspace%3Apackages%2F_metapackage"
   dependencies:
     "@jupyterlab/ui-components": ^4.0.0-alpha.37
     react: ^18.2.0
     react-dom: ^18.2.0
-  checksum: 97d69ff07ea598cccb1ca26e41ed7b2bcfa2930ada04259f93cabe8a681248bbe7233edba759aa65ce2d0f8951300b0405fa4ed2f017158dfcadd3c6378aebe0
+  checksum: 58456d91a833778f16954ede5b074264da62e2d7ad72ea48e90660a52c3186ae564a16a9a0354974f5ddc515f36a9f3e742e914d790bf3d355aa1b98b723d80d
   languageName: node

This one is likely due to the formatting fix from the last commit. Running jlpm (yarn 3) again seems to be updating the yarn.lock.

@jtpio
Copy link
Member Author

jtpio commented Mar 20, 2023

Looking good so far, gonna do a check on Binder as well.

@jtpio jtpio marked this pull request as ready for review March 20, 2023 10:32
@jtpio
Copy link
Member Author

jtpio commented Mar 20, 2023

So it looks like the checksum for locally linked files (referenced from the metapackage) changes easily.

This was likely because of the file: references in the metapackage. Switching to specifying the versions directly in 26c2137 should fix, because the packages are already linked anyway in dev mode.

@jtpio jtpio merged commit 7903de8 into jupyter:main Mar 20, 2023
@jtpio jtpio deleted the update-lab-4a37 branch March 20, 2023 12:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to JupyterLab 4.0.0a37
1 participant