Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Don't format logs in log call. #336

Merged
merged 1 commit into from
Jan 24, 2023
Merged

MAINT: Don't format logs in log call. #336

merged 1 commit into from
Jan 24, 2023

Commits on Jan 24, 2023

  1. MAINT: Don't format logs in log call. 

    In particular f-string:

There are many reason not to use f-string in logs,
 - F-strings are eager, so might be slow.
 - prevent structured logging or handler to highlight.
 - Security (untrusted input can lead to DOS on formatting, https://discuss.python.org/t/safer-logging-methods-for-f-strings-and-new-style-formatting/13802)
 - Performance (we can filter before formatting).

But also % formatting in a couple of places.

See jupyter_client/jupyter_client#919 ipython/ipython#13903
    @Carreau
    Carreau committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    80367a0 View commit details
    Browse the repository at this point in the history