Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI and drop py3.7 #236

Merged
merged 8 commits into from Dec 8, 2023
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 5, 2023

Python 3.7 is EOL. Clean up CI and test all current Python versions.
Update readthedocs config.

Fixes #230. Fixes #232

@blink1073
Copy link
Member Author

@akhmerov can you please add blink1073 to https://readthedocs.org/projects/jupyter-sphinx/ so I can set up the PR build integration?

tests:

strategy:
matrix:
python-version: [3.7, 3.8]
python-version: ["3.8", "3.11", " 3.12"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why you are not testing all python version on ubuntu and only latest on extra platform (mac and windows). This is what I have been doing so far in other repo but now I'm questioning myself....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@12rambau
Copy link
Contributor

12rambau commented Dec 5, 2023

Fix #230

@12rambau
Copy link
Contributor

12rambau commented Dec 5, 2023

@akhmerov if you can add 12rambau as well that would be good. AS it's a sphinx extension sometime you just want to retrigger the PR doc build instead of the whole test suit and you can only do that with admin rights.

@akhmerov
Copy link
Member

akhmerov commented Dec 5, 2023

@blink1073 done!

@12rambau I see this:

image

@akhmerov
Copy link
Member

akhmerov commented Dec 5, 2023

@blink1073 @12rambau thank you for stepping in!

@12rambau
Copy link
Contributor

12rambau commented Dec 5, 2023

@blink1073 done!

@12rambau I see this:

image

You are right, I'm "borntobealive" over there (same knight avatar if it helps)

@akhmerov
Copy link
Member

akhmerov commented Dec 5, 2023

@blink1073 another RTD-related issue: the webhook integration listed here needs to be updated with a secret, and I cannot do this because of not having sufficient github permissions for this repo.

@blink1073
Copy link
Member Author

Thanks @akhmerov, I created a new webhook, and it is working now

@12rambau
Copy link
Contributor

12rambau commented Dec 8, 2023

@blink1073, Is this ready to merge or you have other requests related to the build ?

@blink1073
Copy link
Member Author

you have other requests related to the build ?

Yes, but in follow up PRs. :)

@blink1073 blink1073 merged commit 3451732 into jupyter:master Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with Sphinx 7.2 circle CI seems broken
3 participants