chore: refine IClassicCom types
#3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sweet, thank you! |
martinRenou
force-pushed
the
manzt/optional
branch
from
fe44abf
to
8e4a1f9
Compare
|
Thanks @manzt and thanks for the review @martinRenou |
|
meeseeksdev please backport to 0.12.x |
|
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
|
indeed, wrong repo |
|
close :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is heavy use of
anyinIClassicComtypes but then the wrapper in Widget adds unecessary strictness. These types are forwarded by anywidget and raise type errors downstream for seemingly valid arguments: https://twitter.com/domoritz/status/1637504802543345666This PR adds more precise types and relaxes the strictness of
Widget.sendto makecallbacksoptional.cc: @domoritz