Replace datalist children instead of appending #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongrout
force-pushed
the
replacedatalist
branch
from
7a6d36c
to
210d5f6
Compare
jasongrout
force-pushed
the
replacedatalist
branch
from
210d5f6
to
cc1f9b8
Compare
|
I tried to patch the js files myself without success. Is there some documentation on how to do that? I could definitively wait for the next release, but now I am just curious to know how to do it! |
ibdafna
approved these changes
Jan 31, 2023
vidartf
reviewed
Feb 17, 2023
| @@ -671,7 +671,7 @@ export class ComboboxView extends TextView { | |||
| o.value = v; | |||
| optionFragment.appendChild(o); | |||
| } | |||
| this.datalist.appendChild(optionFragment); | |||
| this.datalist.replaceChildren(...optionFragment.children); | |||
There was a problem hiding this comment.
Would it not be faster (and more consistent) with this.datalist.replaceChildren(optionFragment) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces datalist children when the options are updated rather than appending them.
I also added a test that shows the problem by failing with the current code and passing with the new code.
Fixes #3681