Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More docs updates #3674

Merged
merged 6 commits into from Jan 28, 2023
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 24, 2023

References

Changes

  • fix jupyterlite wheel paths
  • update branch references: master -> main
  • try to fix binder workflow (haven't seen it re-run yet, because it only fires on pull_request_opened)
  • look at some more sphinx warnings
  • restore full index sidebar
  • rework demo links (less bs (ha!))

@bollwyvl bollwyvl marked this pull request as ready for review January 24, 2023 00:43
@bollwyvl bollwyvl closed this Jan 24, 2023
@bollwyvl bollwyvl reopened this Jan 24, 2023
@bollwyvl
Copy link
Contributor Author

Modulo not knowing if this will fix the binder badge workflow, this is ready for review (and 🎃 merge is again fine).

@agoose77
Copy link
Contributor

These changes are all fantastic.

Minor points:

  • For me, the button icons are misaligned
    image
  • Personally I prefer API Reference to Reference
  • I'd be tempted to move the try buttons to the index page only, maybe as a card?
  • On Awkward Array, we have a quick-links card that might be similarly useful (maybe without the badges for ipywidgets) https://awkward-array.org/doc/main/

@bollwyvl
Copy link
Contributor Author

button icons are misaligned

the first two are actually radios, was trying to "act like a local" and use bootstrap sugar. I'll try a treatment without.

move the try buttons to the index page only,

Could move to the bottom. Actually, it would be lovely to have a sidebar that was "open in lite," next to "edit in github".

API Reference to Reference

I'm just working off the upstream language guidance. There might be things there other than the API at some point, though can't tell what those would be.

@bollwyvl
Copy link
Contributor Author

image

@agoose77
Copy link
Contributor

image

Much better!!

@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 0eea422 into jupyter-widgets:main Jan 28, 2023
@bollwyvl
Copy link
Contributor Author

Cool. I think that's all the high-value stuff that wouldn't require a new release of something.

@jasongrout
Copy link
Member

Cool. I think that's all the high-value stuff that wouldn't require a new release of something.

Thanks again for the massive amount of overhauling you did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants