Stricter typescript + some cleanups #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Be more explicit about the fact that we don't know the output of deserialized output
This also makes it explicit which exceptions from full strictness that we rely on:
- noImplicitThis: Mostly in backbone patch
- strictPropertyInitialization: a bunch of properties initialized during backbone init calls is not covered correctly for this strict check
- strictFunctionTypes: The ISerializer interface makes all the arguments optional to allow simpler definitions (`deserializer: (value: any): unknown => { ... }`). However, this does cause `unpack_models` to be typed
There might have been a good reason why these weren't already narrowed, so should check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the typescript strictness, and makes the exceptions that we need explicit (this will also opt us in to any future TS strictness checks by default). In addition to that, the following changes were made:
Error. With strict checks, TS insists that these areunknown._deserializefrom Tweak some typings #3554: After deserialization, we know we have a dict of something, but have no idea about what is in it, since deserializers can return anything. Ideally we should also make it explicit inISerializersthat the return type is unknown, but this might be a breaking change.. ?unpack_modelsso that it is compatible withISerializers(newly included strictness check will also complain if not). This is because theISerlializersmake all argument optional to allow them to ignore arguments they don't care about, even if the arguments must always be passed by a caller. This is chosen to be the lesser of two evils, but this might be open for discussion.ICallbackscallbacks. Also not clear whether this is an ok change or not.