Change md5 to hash and hash_algorithm, fix incompatibility

jupyter_server/services/contents/filemanager.py

@@ -48,6 +48,7 @@ class FileContentsManager(FileManagerMixin, ContentsManager):
     root_dir = Unicode(config=True)
 
     max_copy_folder_size_mb = Int(500, config=True, help="The max folder size that can be copied")
+    support_md5 = Bool(True, config=False, help="Support md5 argument in `get`")
 
     @default("root_dir")
     def _default_root_dir(self):
@@ -725,6 +726,8 @@ def _human_readable_size(self, size):
 class AsyncFileContentsManager(FileContentsManager, AsyncFileManagerMixin, AsyncContentsManager):
     """An async file contents manager."""
 
+    support_md5 = Bool(True, config=False, help="Support md5 argument in `get`")
+
     @default("checkpoints_class")
     def _checkpoints_class_default(self):
         return AsyncFileCheckpoints

jupyter_server/services/contents/handlers.py

@@ -145,16 +145,17 @@ async def get(self, path=""):
             await self._finish_error(
                 HTTPStatus.NOT_FOUND, f"file or directory {path!r} does not exist"
             )
+        kwargs = {
+            "path": path,
+            "type": type,
+            "format": format,
+            "content": content,
+        }
+        if cm.support_md5:
+            kwargs["md5"] = md5
+
         try:
-            model = await ensure_async(
-                self.contents_manager.get(
-                    path=path,
-                    type=type,
-                    format=format,
-                    content=content,
-                    md5=md5,
-                )
-            )
+            model = await ensure_async(self.contents_manager.get(**kwargs))
             validate_model(model, expect_content=content, expect_md5=md5)
             self._finish_model(model, location=False)
         except web.HTTPError as exc:

jupyter_server/services/contents/manager.py

@@ -111,6 +111,7 @@ def _validate_preferred_dir(self, proposal):
         return value
 
     allow_hidden = Bool(False, config=True, help="Allow access to hidden files")
+    support_md5 = Bool(False, config=False, help="Support md5 argument in `get`")
 
     notary = Instance(sign.NotebookNotary)
 
@@ -447,8 +448,14 @@ def exists(self, path):
         """
         return self.file_exists(path) or self.dir_exists(path)
 
-    def get(self, path, content=True, type=None, format=None, md5=False):
-        """Get a file or directory model."""
+    def get(self, path, content=True, type=None, format=None):
+        """
+        Get a file or directory model.
+
+        If a ContentManager supports calculating the md5 value of a file,
+        `ContentManager.support_md5` should be True and this function will accept an `md5` parameter,
+        will return a dict with an `md5` key.
+        """
         raise NotImplementedError
 
     def save(self, model, path):
@@ -850,7 +857,13 @@ async def exists(self, path):
         )
 
     async def get(self, path, content=True, type=None, format=None):
-        """Get a file or directory model."""
+        """
+        Get a file or directory model.
+
+        If a ContentManager supports calculating the md5 value of a file,
+        ContentManager.support_md5 should be True and this function will accept an md5 parameter,
+        will return a dict with an 'md5' key.
+        """
         raise NotImplementedError
 
     async def save(self, model, path):