Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use APIHandler over JupyterHandler to get CORS OPTIONS #952

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Use APIHandler over JupyterHandler to get CORS OPTIONS #952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19a4cc3
fix: handle CORS OPTIONS request
zhanba Jul 17, 2023
ae82f11
fix: replace JupyterHandler with APIHandler
zhanba Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_packages/jupyter_lsp/jupyter_lsp/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"""
from typing import Optional, Text

from jupyter_server.base.handlers import JupyterHandler
from jupyter_server.base.handlers import APIHandler
from jupyter_server.base.zmqhandlers import WebSocketHandler, WebSocketMixin
from jupyter_server.utils import url_path_join as ujoin

Expand All @@ -11,7 +11,7 @@
from .specs.utils import censored_spec


class BaseHandler(JupyterHandler):
class BaseHandler(APIHandler):
manager = None # type: LanguageServerManager

def initialize(self, manager: LanguageServerManager):
Expand Down