Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use APIHandler over JupyterHandler to get CORS OPTIONS #952

Merged
merged 2 commits into from Oct 8, 2023
Merged

Use APIHandler over JupyterHandler to get CORS OPTIONS #952

merged 2 commits into from Oct 8, 2023

Conversation

zhanba
Copy link
Contributor

@zhanba zhanba commented Jul 17, 2023 •
edited

when deploy jupyter-lsp on server, the GET request may need handle the CORS problem, which means handle OPTIONS request properly.

References

Code changes

  • handle CORS Options request in the same way with jupyter-server

User-facing changes

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch zhanba/jupyterlab-lsp/master

@krassowski krassowski merged commit cb86d0d into jupyter-lsp:main Oct 8, 2023
21 of 26 checks passed
@krassowski krassowski changed the title fix: handle CORS OPTIONS request Use APIHandler over JupyterHandler to get CORS OPTIONS Oct 8, 2023
@zhanba
Copy link
Contributor Author

zhanba commented Nov 16, 2023

@krassowski can we release a new version of jupyter-lsp for this change?

@krassowski
Copy link
Member

@zhanba thanks for the patients, a new release of jupyter-lsp v2.2.1 is out (together with jupyterlab-lsp v5.0.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhanba @krassowski