Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap script #1021

Merged
merged 2 commits into from Nov 25, 2023
Merged

Fix bootstrap script #1021

merged 2 commits into from Nov 25, 2023

Conversation

krassowski
Copy link
Member

Fixes #1017

Code changes

Switched to build-in yarn dedupe instead of a third-party package; it only offers the highest strategy and while there is a port of the old package (yarnpkg/berry#2297 (comment)) I prefer to keep it simple to reduce maintenance. Shall we need to dedupe further we can always run jlpm dlx yarn-berry-deduplicate

Removed lerna bootstrap as it is not supported for berry+ and it seems there is no interest from current lerna maintainers:

Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-bootstrap

@krassowski krassowski merged commit ace7047 into jupyter-lsp:main Nov 25, 2023
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The jlpm bootstrap looks not to be working.
1 participant