Fix completion provider isApplicable() for Console

jupyter-lsp · Nov 25, 2023 · 85d2555 · 85d2555
1 parent ace7047
commit 85d2555
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/jupyterlab-lsp/src/features/completion/overrides.ts b/packages/jupyterlab-lsp/src/features/completion/overrides.ts
@@ -92,6 +92,10 @@ export class EnhancedKernelCompleterProvider extends KernelCompleterProvider {
     }
 
     const manager = this.options.connectionManager;
+    if (!context.widget.hasOwnProperty('path')) {
+      // there is no path for Console as it is not a DocumentWidget
+      return false;
+    }
     const widget = context.widget as IDocumentWidget;
     const adapter = manager.adapters.get(widget.context.path);
 

diff --git a/packages/jupyterlab-lsp/src/features/completion/provider.ts b/packages/jupyterlab-lsp/src/features/completion/provider.ts
@@ -300,6 +300,10 @@ export class CompletionProvider implements ICompletionProvider<CompletionItem> {
       return false;
     }
     const manager = this.options.connectionManager;
+    if (!context.widget.hasOwnProperty('path')) {
+      // there is no path for Console as it is not a DocumentWidget
+      return false;
+    }
     const widget = context.widget as IDocumentWidget;
     const adapter = manager.adapters.get(widget.context.path);
     if (!adapter) {