Fix completion provider isApplicable() for Console (#1023)

jupyter-lsp · Nov 26, 2023 · 14b12f7 · 14b12f7
1 parent ea1b220
commit 14b12f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/jupyterlab-lsp/src/features/completion/overrides.ts b/packages/jupyterlab-lsp/src/features/completion/overrides.ts
@@ -93,6 +93,10 @@ export class EnhancedKernelCompleterProvider extends KernelCompleterProvider {
 
     const manager = this.options.connectionManager;
     const widget = context.widget as IDocumentWidget;
+    if (typeof widget.context === 'undefined') {
+      // there is no path for Console as it is not a DocumentWidget
+      return upstream;
+    }
     const adapter = manager.adapters.get(widget.context.path);
 
     if (!adapter) {

diff --git a/packages/jupyterlab-lsp/src/features/completion/provider.ts b/packages/jupyterlab-lsp/src/features/completion/provider.ts
@@ -301,6 +301,10 @@ export class CompletionProvider implements ICompletionProvider<CompletionItem> {
     }
     const manager = this.options.connectionManager;
     const widget = context.widget as IDocumentWidget;
+    if (typeof widget.context === 'undefined') {
+      // there is no path for Console as it is not a DocumentWidget
+      return false;
+    }
     const adapter = manager.adapters.get(widget.context.path);
     if (!adapter) {
       return false;