Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version number to 2.0.0 in package.json and package-lock.json #228

Merged
merged 3 commits into from Apr 1, 2024

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Apr 1, 2024

Follow-up to #209

@DilumAluthge DilumAluthge mentioned this pull request Apr 1, 2024
@DilumAluthge DilumAluthge marked this pull request as ready for review April 1, 2024 14:22
@DilumAluthge DilumAluthge requested a review from a team as a code owner April 1, 2024 14:22
@DilumAluthge DilumAluthge changed the title package.json: Bump the version number to 2.0.0 Bump the version number to 2.0.0 in package.json and package-lock.json Apr 1, 2024
@DilumAluthge DilumAluthge changed the title Bump the version number to 2.0.0 in package.json and package-lock.json Bump the version number to 2.0.0 in package.json and package-lock.json Apr 1, 2024
@IanButterworth
Copy link
Member

IanButterworth commented Apr 1, 2024

Did you manually edit package-lock.json? It's machine generated by npm install/build and there was a diff when I ran that (that I just pushed).

FWIW, PR style nit.. I find keeping the PR title short and general to the concept "Bump version to 2.0.0" and the detail getting refined in the PR/commits to be a smoother approach with less noise for people following along.

@IanButterworth IanButterworth merged commit b96a572 into master Apr 1, 2024
51 checks passed
@IanButterworth IanButterworth deleted the dpa/bump-version-v2 branch April 1, 2024 14:49
@IanButterworth
Copy link
Member

I'm working on releasing this

@DilumAluthge
Copy link
Member Author

I can run the release script when I get back to my computer, unless you beat me to it.

@IanButterworth
Copy link
Member

https://github.com/julia-actions/setup-julia/releases/tag/v2.0.0

@DilumAluthge
Copy link
Member Author

Narrator: he did indeed beat him to it

@DilumAluthge
Copy link
Member Author

Thank you Ian!

@IanButterworth
Copy link
Member

The script is a little bumpy for me. Notes:

  • This line in the build script fails on MacOS and messes up the rest of the script https://github.com/julia-actions/bin/blob/31b4b500a3f419f3aed06ba1aa640bb41fdb835f/build-release.sh#L33 Error: sed: 1: ".gitignore": invalid command code .
  • The script doesn't check you've got master checked out and up to date. I didn't at first, which resulted in a bad release branch being pushed with non-squashed commits. Then I couldn't fix it because delete and force push is disabled for release branches (I had to disable that momentarily for myself to fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants