Fix the Apple Silicon (macOS aarch64 / arm64) URLs for Julia nightly
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you @benlorenz! I'll take a look. @SaschaMann It would be great if you could take a look too. cc: @ViralBShah - once this is merged and a new release is made, we can use this in the SparseArrays.jl repo. |
DilumAluthge
changed the title
aarch64 / arm64) URLs for Julia nightly
|
@SaschaMann or @IanButterworth If you have time, can you do a post-merge review? |
|
Nice! Is using |
|
I don't think we need the added complexity of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with julia nightly on
macos-14(aarch64) currently fails with:The filename is slightly wrong and should have
macaarch64instead ofmac64, this PR tries to fix this for linux and macOS.I also added
macOS-14(for the new M1 runners) to the nightly tests.Note that these URLs are a bit of a guesswork. On the official nightly downloads page they have a different format using a slightly more homogeneous pattern (at least for linux and macos):
x86_64,i686andaarch64in the baseurl instead ofx64andx86.macosinstead ofmacin the baseurl.julia-latest-<osname>-<arch>Adjusting to this pattern could simplify the code a bit even though it would still need a bunch of extra cases for windows.
But I don't really know anything about the stability of all those URLs.
Edit: Looks like the new tests on the M1 were successful: https://github.com/julia-actions/setup-julia/actions/runs/7855176535/job/21436628690?pr=220#step:5:15