address comments in slsa-framework#3570

jul-sh · Apr 17, 2024 · e280a41 · e280a41
1 parent 8489e8a
commit e280a41
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/internal/builders/docker/pkg/builder.go b/internal/builders/docker/pkg/builder.go
@@ -500,6 +500,7 @@ func saveOneTempFile(verbose bool, reader io.Reader, fileChannel chan tempFileRe
 	tmpfile, err := os.CreateTemp("", "log-*.txt")
 	if err != nil {
 		fileChannel <- tempFileResult{Err: err}
+		tmpfile.Close()
 		return
 	}
 	if _, err := tmpfile.Write(allBytes); err != nil {
@@ -529,13 +530,6 @@ func saveToTempFile(verbose bool, readers ...io.Reader) ([]string, error) {
 		}(reader)
 	}
 
-	// Close the channel once all goroutines have finished.
-	go func() {
-		wg.Wait()
-		close(printChannel)
-		close(fileChannel)
-	}()
-
 	for line := range printChannel {
 		fmt.Println(line)
 	}
@@ -548,6 +542,10 @@ func saveToTempFile(verbose bool, readers ...io.Reader) ([]string, error) {
 		files = append(files, result.File.Name())
 	}
 
+	wg.Wait()
+	close(printChannel)
+	close(fileChannel)
+
 	return files, nil
 }