Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: commitish must point to the name of the branch or tag that triggered the workflow run #14

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

juanjjaramillo
Copy link
Owner

@juanjjaramillo juanjjaramillo commented Sep 25, 2023

Description

This is a long story. It all started when this error appeared. The suggested solution by one of the developers works, but another developer argues it will not work when working with different branches for more elaborate scenarios.

I decided to follow the advice of the developer that makes a better case.

Checklist

Mandatory:

  • PR title is suitable to be included in the release notes

If applicable:

  • Changes have been documented
  • Changes have been manually tested
  • New tests has been added

@juanjjaramillo juanjjaramillo marked this pull request as ready for review September 25, 2023 03:16
@juanjjaramillo juanjjaramillo added the Release/break Introduces a breaking API change label Sep 25, 2023
@juanjjaramillo juanjjaramillo changed the title ci: Revert "ci: Fix ERROR: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}" ci: commitish must point to the name of the branch or tag that triggered the workflow run Sep 25, 2023
@juanjjaramillo juanjjaramillo merged commit d147229 into main Sep 25, 2023
5 checks passed
@juanjjaramillo juanjjaramillo deleted the juanjjaramillo/revert_change branch September 25, 2023 04:04
@juanjjaramillo juanjjaramillo added Release/fix Makes backward-compatible bug fixes Release/break Introduces a breaking API change Release/other Catch-all option for any other changes and removed Release/break Introduces a breaking API change Release/fix Makes backward-compatible bug fixes Release/other Catch-all option for any other changes labels Sep 25, 2023
alankritdabral added a commit to alankritdabral/testbed that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant