Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add download page #1949

Closed
wants to merge 3 commits into from
Closed

add download page #1949

wants to merge 3 commits into from

Conversation

IamTaoChen
Copy link

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Add a download page to indicate where can download Tailscale and a link to know how to use it.
image

@ohdearaugustin
Copy link
Collaborator

I think this is a feature.

First of all it is not 100% clear that this will download the client and not headscale itself.

As the clients are not maintained by this project, we would add an external dependency we have to track. Furthermore, I don't see the value of adding this extra download page. Maybe you can clarify the use case of it, as I don't see one.

Furthermore no documentation and unittests for the endpoint.

@IamTaoChen
Copy link
Author

IamTaoChen commented May 19, 2024

I think this is a feature.

First of all it is not 100% clear that this will download the client and not headscale itself.

As the clients are not maintained by this project, we would add an external dependency we have to track. Furthermore, I don't see the value of adding this extra download page. Maybe you can clarify the use case of it, as I don't see one.

Furthermore no documentation and unittests for the endpoint.

I use this page to tell my group members how to use headsacle. before, I need to ask them which OS they are using and give them the corresponding link. And now, I only need send this one page. Here is a demo https://vpn.demo8.org/download. I would say it copy from Tailscale, I ask chatgpt to write this html.

@IamTaoChen
Copy link
Author

I also have another solution. change the the file name to download.html and put it at /var/www/headscale the add the

    RewriteEngine On
    RewriteCond %{REQUEST_URI} ^/download$
    RewriteRule ^/download$ /var/www/headscale/download.html [L]
    Alias /download /var/www/headscale/download.html

to apache2 config file.

download.html.txt

@kradalby
Copy link
Collaborator

As the clients are not maintained by this project, we would add an external dependency we have to track. Furthermore, I don't see the value of adding this extra download page.

I agree with this, it is not great linking to external sources and the URL might change which means that people with old headscales will have download pages with broken links. I think the benefit of this vs going to pkgs.tailscale.com or tailscale.com/download is not outweighing the potential maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants