-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HostInfo output to Node response #1938
base: main
Are you sure you want to change the base?
Conversation
…troCodeName) output to Node response
@juanfont, I saw your comment #1205 (comment) but I think that adding the base fields from HostInfo will not affect the HeadScale in any way, because it is unlikely that TailScale will change the fields used in any way |
Quoting the issue referred above:
We cannot maintain all these field hand typed into the API, however just marshalling it as JSON and then unmarshalling it on the other side using If this is implemented, it should also be part of the JSON output of As mentioned in our contribution guidelines, all contributions needs tests and there are a few more tickboxes that has not been addressed. |
Replaced with marshaling in JSON (protobuf.Struct). |
Usecase
As an administrator, I want to see the information that is available only in HostInfo, for example, the version of the client's TailScale, the OS name, its version, etc.