new IP allocator and add postgres to integration tests. #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
postgres-tests
branch
3 times, most recently
from
6296b05
to
da45a20
Compare
kradalby
changed the title
kradalby
force-pushed
the
postgres-tests
branch
from
6f2deb1
to
6f17ca3
Compare
This new allocator keeps the used space in memory and loads the database only on startup. If it allocates but something errors before it gets saved to the database, then thats fine because it will be cleared on next restart. This should resolve races between ip allocation with postgres and as a side effect should make it easier to implement random allocation instead of serial if we so desire. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
postgres-tests
branch
from
6f17ca3
to
9f91990
Compare
kradalby
changed the title
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
postgres-tests
branch
from
9f91990
to
93104b2
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit removes the old IP allocation logic which means that we no longer need to pass IP Prefixes all around the place, this allowed us to clean up some quite racy database code and addresses are now allocated before interacting with the database and fetched before registering the machines. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
postgres-tests
branch
from
93104b2
to
f59db05
Compare
juanfont
reviewed
Feb 18, 2024
| @@ -98,6 +99,10 @@ func (api headscaleV1APIServer) ListUsers( | |||
| response[index] = user.Proto() | |||
| } | |||
|
|
|||
| sort.Slice(response, func(i, j int) bool { | |||
juanfont
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new IP allocator which should be more efficient, stable and less racy. This was necessary to deal with a discovered race condition in the allocation after adding postgresql integration tests.
I believe this is replacing the first "real" code I contributed to the project, and man, that was ver much needed 馃槅.
In addition it adds a new option to the integration tests to run them against postgresql instead of sqlite to ensure we do not have this regression again.
The last commit is the generation of new gh actions jobs and can be ignored as generated.
Fixes #1755
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com