Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] jsx-one-expression-per-line: add non-jsx option to allow non-JSX children in one line #3677

Merged
merged 1 commit into from Jan 12, 2024
Merged

[New] jsx-one-expression-per-line: add non-jsx option to allow non-JSX children in one line #3677

merged 1 commit into from Jan 12, 2024

Conversation

burtek
Copy link
Contributor

@burtek burtek commented Jan 11, 2024

Fixes #3669

@burtek burtek marked this pull request as ready for review January 11, 2024 17:04
@burtek burtek force-pushed the jsx-one-expression-per-line branch from 886eac9 to e8cef50 Compare January 11, 2024 17:05
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1014f8c) 97.74% compared to head (592484c) 97.74%.

❗ Current head 592484c differs from pull request most recent head 9f4b2b9. Consider uploading reports for the commit 9f4b2b9 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3677   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         132      132           
  Lines        9405     9409    +4     
  Branches     3446     3449    +3     
=======================================
+ Hits         9193     9197    +4     
  Misses        212      212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ljharb
ljharb requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

lib/rules/jsx-one-expression-per-line.js Outdated Show resolved Hide resolved
@burtek burtek force-pushed the jsx-one-expression-per-line branch from 4834dd6 to 592484c Compare January 11, 2024 19:06
@burtek burtek requested a review from ljharb January 11, 2024 19:07
@ljharb ljharb force-pushed the jsx-one-expression-per-line branch from 592484c to 9f4b2b9 Compare January 12, 2024 06:00
@ljharb ljharb closed this Jan 12, 2024
@ljharb ljharb reopened this Jan 12, 2024
@ljharb ljharb merged commit 9f4b2b9 into jsx-eslint:master Jan 12, 2024
311 checks passed
@burtek burtek deleted the jsx-one-expression-per-line branch January 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New option: jsx-one-expression-per-line non-jsx
2 participants
@burtek @ljharb