[jsx-no-script-url]: use shared settings to specify link components

[burtek]

Fixes #2865

[burtek]

I'm probably gonna need to change getLinkComponents util to allow multiple props for single component. You can't really give it MyComponent with two different props at this time, while jsx-no-script-url allows that. Am thinking about changing a string prop linkAttribute to a string array prop linkAttributes (and internally mapping linkAttribute to linkAttributes: [linkAttribute] for backwards compatibility).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3730edb) 97.65% compared to head (1d15932) 97.74%.

❗ Current head 1d15932 differs from pull request most recent head 1014f8c. Consider uploading reports for the commit 1014f8c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3673      +/-   ##
==========================================
+ Coverage   97.65%   97.74%   +0.08%     
==========================================
  Files         132      132              
  Lines        9397     9404       +7     
  Branches     3445     3443       -2     
==========================================
+ Hits         9177     9192      +15     
+ Misses        220      212       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ljharb]

This looks good.

I've split the PR into two commits - the first one is objectively semver-minor, and has the "multiple properties" feature.

The second, though, I'm a bit uncertain if it's semver-minor or semver-major. Could there be someone relying on linkAttributes not applying to this rule?

[burtek]

I don't know. Myself I have this plugin configured in multiple projects (both my own and at work) and we always had to duplicate the setup for this rule.

That being said, that's why the first implementation had the rule option override global settings - that way it wouldn't be a breaking change.

[ljharb]

hmm.

even for the case where the rule option wasn't passed, though, someone might have the link components setting and expect the rule NOT to warn on them, no?

[burtek]

Yeah, you might be right actually.

I'm fine with this PR being marked as semver-major

[ljharb]

Unfortunately that'd delay it from landing probably indefinitely.

How about instead, we modify the second commit so that an additional option is required, a boolean which defaults to false, that enables hooking in the linkComponents (whether the existing option is provided or not)?

[burtek]

I can do that

[burtek]

@ljharb how about now? :)