Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node.start/node.end with node.range[0]/node.range[1], respectively #1496

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Replace node.start/node.end with node.range[0]/node.range[1], respectively #1496

merged 1 commit into from
Oct 24, 2017
+18 −18

Conversation

timothykang
Copy link
Contributor

Usage of non-standard .start/.end properties causes failures when they aren't set by some parsers that follow the official AST (e.g. typescript-eslint-parser).

See: eslint/eslint#8956

ljharb
ljharb approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable.

@ljharb ljharb merged commit e9e33cf into jsx-eslint:master Oct 24, 2017
@dependencies dependencies bot mentioned this pull request Nov 19, 2017
Merged
This was referenced Dec 15, 2017
Open
Closed
This was referenced Feb 2, 2018
Closed
Closed
Closed
Open
Open
Merged
Merged
@dependencies dependencies bot mentioned this pull request Mar 1, 2018
Open
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
Open
Open
Open
Closed
Open
This was referenced Oct 25, 2018
Merged
Open
@renovate renovate bot mentioned this pull request Nov 7, 2018
Merged
@renovate renovate bot mentioned this pull request Nov 23, 2018
Open
1 task
@renovate renovate bot mentioned this pull request Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this pull request Dec 19, 2018
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 6, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Sep 14, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Oct 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timothykang @ljharb