[Refactor] context.getSource -> sourceCode.getText

jsx-eslint · May 19, 2024 · 2bc74ca · 2bc74ca
1 parent 65f10f9
commit 2bc74ca
Show file tree

Hide file tree

Showing 37 changed files with 144 additions and 121 deletions.
diff --git a/lib/rules/boolean-prop-naming.js b/lib/rules/boolean-prop-naming.js
@@ -13,7 +13,10 @@ const propsUtil = require('../util/props');
 const docsUrl = require('../util/docsUrl');
 const propWrapperUtil = require('../util/propWrapper');
 const report = require('../util/report');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const eslintUtil = require('../util/eslint');
+
+const getSourceCode = eslintUtil.getSourceCode;
+const getText = eslintUtil.getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -309,7 +312,7 @@ module.exports = {
           && node.value.type === 'CallExpression'
           && propWrapperUtil.isPropWrapperFunction(
             context,
-            getSourceCode(context).getText(node.value.callee)
+            getText(context, node.value.callee)
           )
         ) {
           checkPropWrapperArguments(node, node.value.arguments);
@@ -335,7 +338,7 @@ module.exports = {
           right.type === 'CallExpression'
           && propWrapperUtil.isPropWrapperFunction(
             context,
-            getSourceCode(context).getText(right.callee)
+            getText(context, right.callee)
           )
         ) {
           checkPropWrapperArguments(component.node, right.arguments);

diff --git a/lib/rules/destructuring-assignment.js b/lib/rules/destructuring-assignment.js
@@ -10,7 +10,7 @@ const eslintUtil = require('../util/eslint');
 const isAssignmentLHS = require('../util/ast').isAssignmentLHS;
 const report = require('../util/report');
 
-const getSourceCode = eslintUtil.getSourceCode;
+const getText = eslintUtil.getText;
 
 const DEFAULT_OPTION = 'always';
 
@@ -272,7 +272,7 @@ module.exports = {
                 param.typeAnnotation ? param.typeAnnotation.range[0] : param.range[1],
               ];
               return [
-                fixer.replaceTextRange(replaceRange, getSourceCode(context).getText(node.id)),
+                fixer.replaceTextRange(replaceRange, getText(context, node.id)),
                 fixer.remove(node.parent),
               ];
             },

diff --git a/lib/rules/forbid-elements.js b/lib/rules/forbid-elements.js
@@ -7,7 +7,7 @@
 
 const has = require('object.hasown/polyfill')();
 const docsUrl = require('../util/docsUrl');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 const isCreateElement = require('../util/isCreateElement');
 const report = require('../util/report');
 
@@ -91,7 +91,7 @@ module.exports = {
 
     return {
       JSXOpeningElement(node) {
-        reportIfForbidden(getSourceCode(context).getText(node.name), node.name);
+        reportIfForbidden(getText(context, node.name), node.name);
       },
 
       CallExpression(node) {
@@ -111,7 +111,7 @@ module.exports = {
         } else if (argType === 'Literal' && /^[a-z][^.]*$/.test(argument.value)) {
           reportIfForbidden(argument.value, argument);
         } else if (argType === 'MemberExpression') {
-          reportIfForbidden(getSourceCode(context).getText(argument), argument);
+          reportIfForbidden(getText(context, argument), argument);
         }
       },
     };

diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -10,7 +10,7 @@ const astUtil = require('../util/ast');
 const docsUrl = require('../util/docsUrl');
 const propWrapperUtil = require('../util/propWrapper');
 const report = require('../util/report');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 
 // ------------------------------------------------------------------------------
 // Constants
@@ -172,7 +172,7 @@ module.exports = {
         case 'CallExpression': {
           const innerNode = node.arguments && node.arguments[0];
           if (
-            propWrapperUtil.isPropWrapperFunction(context, getSourceCode(context).getText(node.callee))
+            propWrapperUtil.isPropWrapperFunction(context, getText(context, node.callee))
             && innerNode
           ) {
             checkNode(innerNode);

diff --git a/lib/rules/function-component-definition.js b/lib/rules/function-component-definition.js
@@ -9,7 +9,7 @@ const arrayIncludes = require('array-includes');
 const Components = require('../util/Components');
 const docsUrl = require('../util/docsUrl');
 const reportC = require('../util/report');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -182,8 +182,7 @@ module.exports = {
     );
 
     function getFixer(node, options) {
-      const sourceCode = getSourceCode(context);
-      const source = sourceCode.getText();
+      const source = getText(context);
 
       const typeAnnotation = getTypeAnnotation(node, source);
 

diff --git a/lib/rules/hook-use-state.js b/lib/rules/hook-use-state.js
@@ -9,7 +9,7 @@ const Components = require('../util/Components');
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
 const getMessageData = require('../util/message');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -168,7 +168,7 @@ module.exports = {
                   // Convert useState call to useMemo + arrow function + dependency array
                   fixer.replaceTextRange(
                     node.range,
-                    `${useMemoCode}(() => ${getSourceCode(context).getText(node.arguments[0])}, [])`
+                    `${useMemoCode}(() => ${getText(context, node.arguments[0])}, [])`
                   ),
                 ].filter(Boolean),
               }

diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -11,7 +11,10 @@ const arrayIncludes = require('array-includes');
 const docsUrl = require('../util/docsUrl');
 const jsxUtil = require('../util/jsx');
 const report = require('../util/report');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const eslintUtil = require('../util/eslint');
+
+const getSourceCode = eslintUtil.getSourceCode;
+const getText = eslintUtil.getText;
 
 // ------------------------------------------------------------------------------
 // Constants
@@ -177,8 +180,7 @@ module.exports = {
 
           let textToReplace;
           if (jsxUtil.isJSX(expression)) {
-            const sourceCode = getSourceCode(context);
-            textToReplace = sourceCode.getText(expression);
+            textToReplace = getText(context, expression);
           } else {
             const expressionType = expression && expression.type;
             const parentType = JSXExpressionNode.parent.type;
@@ -189,9 +191,7 @@ module.exports = {
                 : expression.raw.slice(1, -1)
               }"`;
             } else if (jsxUtil.isJSX(expression)) {
-              const sourceCode = getSourceCode(context);
-
-              textToReplace = sourceCode.getText(expression);
+              textToReplace = getText(context, expression);
             } else {
               textToReplace = expressionType === 'TemplateLiteral'
                 ? expression.quasis[0].value.cooked : expression.value;
@@ -208,7 +208,7 @@ module.exports = {
         node: literalNode,
         fix(fixer) {
           if (jsxUtil.isJSX(literalNode)) {
-            return fixer.replaceText(literalNode, `{${getSourceCode(context).getText(literalNode)}}`);
+            return fixer.replaceText(literalNode, `{${getText(context, literalNode)}}`);
           }
 
           // If a HTML entity name is found, bail out because it can be fixed

diff --git a/lib/rules/jsx-curly-newline.js b/lib/rules/jsx-curly-newline.js
@@ -5,9 +5,12 @@
 'use strict';
 
 const docsUrl = require('../util/docsUrl');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const eslintUtil = require('../util/eslint');
 const report = require('../util/report');
 
+const getSourceCode = eslintUtil.getSourceCode;
+const getText = eslintUtil.getText;
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -131,8 +134,7 @@ module.exports = {
         report(context, messages.unexpectedAfter, 'unexpectedAfter', {
           node: leftCurly,
           fix(fixer) {
-            return sourceCode
-              .getText()
+            return getText(context)
               .slice(leftCurly.range[1], tokenAfterLeftCurly.range[0])
               .trim()
               ? null // If there is a comment between the { and the first element, don't do a fix.
@@ -150,8 +152,7 @@ module.exports = {
         report(context, messages.unexpectedBefore, 'unexpectedBefore', {
           node: rightCurly,
           fix(fixer) {
-            return sourceCode
-              .getText()
+            return getText(context)
               .slice(tokenBeforeRightCurly.range[1], rightCurly.range[0])
               .trim()
               ? null // If there is a comment between the last element and the }, don't do a fix.

diff --git a/lib/rules/jsx-fragments.js b/lib/rules/jsx-fragments.js
@@ -11,7 +11,7 @@ const variableUtil = require('../util/variable');
 const testReactVersion = require('../util/version').testReactVersion;
 const docsUrl = require('../util/docsUrl');
 const report = require('../util/report');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -66,36 +66,34 @@ module.exports = {
     }
 
     function getFixerToLong(jsxFragment) {
-      const sourceCode = getSourceCode(context);
       if (!jsxFragment.closingFragment || !jsxFragment.openingFragment) {
         // the old TS parser crashes here
         // TODO: FIXME: can we fake these two descriptors?
         return null;
       }
       return function fix(fixer) {
-        let source = sourceCode.getText();
+        let source = getText(context);
         source = replaceNode(source, jsxFragment.closingFragment, closeFragLong);
         source = replaceNode(source, jsxFragment.openingFragment, openFragLong);
-        const lengthDiff = openFragLong.length - sourceCode.getText(jsxFragment.openingFragment).length
-          + closeFragLong.length - sourceCode.getText(jsxFragment.closingFragment).length;
+        const lengthDiff = openFragLong.length - getText(context, jsxFragment.openingFragment).length
+          + closeFragLong.length - getText(context, jsxFragment.closingFragment).length;
         const range = jsxFragment.range;
         return fixer.replaceTextRange(range, source.slice(range[0], range[1] + lengthDiff));
       };
     }
 
     function getFixerToShort(jsxElement) {
-      const sourceCode = getSourceCode(context);
       return function fix(fixer) {
-        let source = sourceCode.getText();
+        let source = getText(context);
         let lengthDiff;
         if (jsxElement.closingElement) {
           source = replaceNode(source, jsxElement.closingElement, closeFragShort);
           source = replaceNode(source, jsxElement.openingElement, openFragShort);
-          lengthDiff = sourceCode.getText(jsxElement.openingElement).length - openFragShort.length
-            + sourceCode.getText(jsxElement.closingElement).length - closeFragShort.length;
+          lengthDiff = getText(context, jsxElement.openingElement).length - openFragShort.length
+            + getText(context, jsxElement.closingElement).length - closeFragShort.length;
         } else {
           source = replaceNode(source, jsxElement.openingElement, `${openFragShort}${closeFragShort}`);
-          lengthDiff = sourceCode.getText(jsxElement.openingElement).length - openFragShort.length
+          lengthDiff = getText(context, jsxElement.openingElement).length - openFragShort.length
             - closeFragShort.length;
         }
 

diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -6,7 +6,7 @@
 'use strict';
 
 const docsUrl = require('../util/docsUrl');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 const report = require('../util/report');
 
 // ------------------------------------------------------------------------------
@@ -130,10 +130,10 @@ module.exports = {
 
         const propKey = typeof node.name === 'object' ? node.name.name : node.name;
         const expression = node.value.expression;
-        const propValue = getSourceCode(context)
-          .getText(checkInlineFunction && isInlineHandler(node) ? expression.body.callee : expression)
-          .replace(/\s*/g, '')
-          .replace(/^this\.|.*::/, '');
+        const propValue = getText(
+          context,
+          checkInlineFunction && isInlineHandler(node) ? expression.body.callee : expression
+        ).replace(/\s*/g, '').replace(/^this\.|.*::/, '');
 
         if (propKey === 'ref') {
           return;

diff --git a/lib/rules/jsx-indent-props.js b/lib/rules/jsx-indent-props.js
@@ -32,7 +32,7 @@
 
 const astUtil = require('../util/ast');
 const docsUrl = require('../util/docsUrl');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 const reportC = require('../util/report');
 
 // ------------------------------------------------------------------------------
@@ -141,7 +141,7 @@ module.exports = {
      * @return {Number} Indent
      */
     function getNodeIndent(node) {
-      let src = getSourceCode(context).getText(node, node.loc.start.column + extraColumnStart);
+      let src = getText(context, node, node.loc.start.column + extraColumnStart);
       const lines = src.split('\n');
       src = lines[0];
 

diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -36,7 +36,10 @@ const astUtil = require('../util/ast');
 const docsUrl = require('../util/docsUrl');
 const reportC = require('../util/report');
 const jsxUtil = require('../util/jsx');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const eslintUtil = require('../util/eslint');
+
+const getSourceCode = eslintUtil.getSourceCode;
+const getText = eslintUtil.getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -117,7 +120,7 @@ module.exports = {
       }
 
       if (node.type === 'ReturnStatement') {
-        const raw = getSourceCode(context).getText(node);
+        const raw = getText(context, node);
         const lines = raw.split('\n');
         if (lines.length > 1) {
           return function fix(fixer) {
@@ -169,7 +172,7 @@ module.exports = {
      * @return {Number} Indent
      */
     function getNodeIndent(node, byLastLine, excludeCommas) {
-      let src = getSourceCode(context).getText(node, node.loc.start.column + extraColumnStart);
+      let src = getText(context, node, node.loc.start.column + extraColumnStart);
       const lines = src.split('\n');
       if (byLastLine) {
         src = lines[lines.length - 1];

diff --git a/lib/rules/jsx-key.js b/lib/rules/jsx-key.js
@@ -12,7 +12,7 @@ const docsUrl = require('../util/docsUrl');
 const pragmaUtil = require('../util/pragma');
 const report = require('../util/report');
 const astUtil = require('../util/ast');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 
 // ------------------------------------------------------------------------------
 // Rule Definition
@@ -214,7 +214,7 @@ module.exports = {
             }
           } else {
             keys.forEach((attr) => {
-              const value = getSourceCode(context).getText(attr.value);
+              const value = getText(context, attr.value);
               if (!map[value]) { map[value] = []; }
               map[value].push(attr);
 

diff --git a/lib/rules/jsx-max-props-per-line.js b/lib/rules/jsx-max-props-per-line.js
@@ -6,12 +6,12 @@
 'use strict';
 
 const docsUrl = require('../util/docsUrl');
-const getSourceCode = require('../util/eslint').getSourceCode;
+const getText = require('../util/eslint').getText;
 const report = require('../util/report');
 
 function getPropName(context, propNode) {
   if (propNode.type === 'JSXSpreadAttribute') {
-    return getSourceCode(context).getText(propNode.argument);
+    return getText(context, propNode.argument);
   }
   return propNode.name.name;
 }
@@ -88,7 +88,6 @@ module.exports = {
       };
 
     function generateFixFunction(line, max) {
-      const sourceCode = getSourceCode(context);
       const output = [];
       const front = line[0].range[0];
       const back = line[line.length - 1].range[1];
@@ -97,9 +96,9 @@ module.exports = {
         const nodes = line.slice(i, i + max);
         output.push(nodes.reduce((prev, curr) => {
           if (prev === '') {
-            return sourceCode.getText(curr);
+            return getText(context, curr);
           }
-          return `${prev} ${sourceCode.getText(curr)}`;
+          return `${prev} ${getText(context, curr)}`;
         }, ''));
       }