Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against a missing process.env (as in the browser) #322

Merged
merged 1 commit into from Sep 25, 2023

Conversation

pvh
Copy link
Contributor

@pvh pvh commented Sep 25, 2023

When there's no process.env, the check above fails. This just guards it.

@pvh
Copy link
Contributor Author

pvh commented Sep 25, 2023

Just a tiny PR as I get back into working on this stuff. You can obviously polyfill process but vite makes it annoying and it would be nicer not to have to!

@guybedford guybedford merged commit c1c3ebd into jspm:main Sep 25, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants