Add option to skip validation of license names #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed my pull request is similar to #16. It would help me out a lot if one of those two was merged with your project. I believe my version is more light-weight, but it only works with Node.js 6 or higher, since I use a default value for the optional argument. |
|
@julienandco someone else was interested in this, too. I believe the Microsoft folks may actually be running a fork for this purpose. |
ljharb
reviewed
Sep 10, 2019
index.js
Outdated
| @@ -3,6 +3,6 @@ | |||
| var scan = require('./scan') | |||
| var parse = require('./parse') | |||
|
|
|||
| module.exports = function (source) { | |||
| return parse(scan(source)) | |||
| module.exports = function (source, validateLicenseNames = true) { | |||
There was a problem hiding this comment.
typically i'd expect absence and false to be the same for boolean options; this should probably be inverted so it can default to false?
There was a problem hiding this comment.
You are absolutely right, I will change this.
added 2 commits
September 11, 2019 14:39
kemitchell
force-pushed
the
main
branch
2 times, most recently
from
ce3167f
to
19f25b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows the parsing of license names that are not listed in the spdx-license-ids module.