Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for options with descriptions for combobox and dropdown #3371

Merged
merged 16 commits into from
May 28, 2024

Conversation

ThusharaJ07
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 6c599b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 7, 2024

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 8:52am

@origami-z
Copy link
Contributor

In #3431, gap between labels are 0.5, maybe this should be updated as well?

@ThusharaJ07
Copy link
Contributor Author

In #3431, gap between labels are 0.5, maybe this should be updated as well?

updated the gap to 0.5

origami-z
origami-z previously approved these changes May 21, 2024
joshwooding
joshwooding previously approved these changes May 24, 2024
@joshwooding joshwooding marked this pull request as ready for review May 28, 2024 08:45
@joshwooding joshwooding changed the title added examples for secondary label for combobox Add examples for options with descriptions for combobox and dropdown May 28, 2024
@joshwooding joshwooding merged commit 38518f4 into jpmorganchase:main May 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants