Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation pattern example #3299

Merged
merged 4 commits into from
May 23, 2024
Merged

Navigation pattern example #3299

merged 4 commits into from
May 23, 2024

Conversation

lilyvc
Copy link
Contributor

@lilyvc lilyvc commented Apr 24, 2024

Adds an example of Navigation layout to storybook

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 2ea2a4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 8:10am

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Storybook Preview Link https://9b85d8d1.saltdesignsystem-storybook.pages.dev

Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need something to show best practice of small viewport?
This could be a good place to think how to reuse other pattern code

@lilyvc
Copy link
Contributor Author

lilyvc commented Apr 26, 2024

Need something to show best practice of small viewport? This could be a good place to think how to reuse other pattern code

There's no guidance on the pattern page about small viewport, so I'm actually not sure of the approach if you have a sidebar and vertical nav and it's mobile. This could be follow up work, this is more just to catch up the examples to the patterns page.

@origami-z
Copy link
Contributor

This could be follow up work, this is more just to catch up the examples to the patterns page.

OK, created #3344

@origami-z origami-z merged commit e48d7df into main May 23, 2024
15 checks passed
@origami-z origami-z deleted the navigation-pattern-example branch May 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants