Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Next: unified color palette #3255

Merged
merged 33 commits into from
May 22, 2024
Merged

Theme Next: unified color palette #3255

merged 33 commits into from
May 22, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Apr 16, 2024

Apply new unified color palette (foundation) when using UNSTABLE_SaltProviderNext, with remapped palette and characteristics layer as well. This does not introduce new Button design (w/ top/bottom border states) but still using existing background change. This however does introduce mode agnostic Buttons, a.k.a. Button in both light and dark mode will share the same color / state.

Note ag grid theme doesn't work in theme next, mostly due to default color applied. We don't care about them for now, and will be easily fixed when v31 ag grid support is released.

  • Final color swatch r8 revision
  • Button color mapping check

Added border to button to accommodate new design. This means some components / test are touched

  • Button, to keep visual regression the same, updated padding to deduct border
  • Segmented button separator changed implementation to have full height stroke
  • Input, Multiline Input, Pill Input, updated padding to deduct border

Replace #3032

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 09d4ce5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:00pm

@origami-z origami-z changed the title Unified color palette Unified color palette for theme next Apr 17, 2024
@origami-z origami-z marked this pull request as ready for review April 17, 2024 13:35
@origami-z origami-z marked this pull request as draft April 17, 2024 13:36
@origami-z origami-z merged commit eaab9d8 into main May 22, 2024
15 checks passed
@origami-z origami-z deleted the unified-color-palette branch May 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants