Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ag grid theme major - support v31 #3195

Merged
merged 30 commits into from
May 24, 2024
Merged

Ag grid theme major - support v31 #3195

merged 30 commits into from
May 24, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Apr 3, 2024

Do not merge this before #3364 is released

Next major update to support ag grid v31

  • New AG grid variables support
  • Removed UITK theme
  • Massively reduce bundle size from 1,600 kB to < 25 kB

To use / test

Latest snapshot:
-@salt-ds/ag-grid-theme@0.0.0-snapshot-20240523122351
-@salt-ds/theme@0.0.0-snapshot-20240523122351

Test bed on StackBlitz: https://stackblitz.com/edit/salt-ag-grid-theme-mgguyf?file=App.jsx

Import css

import "ag-grid-community/styles/ag-grid.css"; // Updated from ag grid
import "@salt-ds/ag-grid-theme/salt-ag-theme.css";  // Changed from `/salt.css` from early v30 snapshot

Class names on container changed, e.g.

.ag-theme-salt-light
.ag-theme-salt-compact-light
  • Review site doc

Reported issues

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 8ff3ec8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/theme Minor
@salt-ds/ag-grid-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 1:42pm

@origami-z
Copy link
Contributor Author

/release-pr

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Apr 4, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20240404100001
yarn add @salt-ds/core@0.0.0-snapshot-20240404100001
yarn add @salt-ds/icons@0.0.0-snapshot-20240404100001
yarn add @salt-ds/lab@0.0.0-snapshot-20240404100001

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Apr 4, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/ag-grid-theme@0.0.0-snapshot-20240404100545
yarn add @salt-ds/core@0.0.0-snapshot-20240404100545

@origami-z origami-z merged commit 5ed8ed8 into main May 24, 2024
15 checks passed
@origami-z origami-z deleted the ag-grid-next-v31 branch May 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants