Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] json for theme 2.0 #3143

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

[WIP] json for theme 2.0 #3143

wants to merge 50 commits into from

Conversation

libertymayc
Copy link
Contributor

Builds from color-palette-next branch to use salt theme 2.0

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited

🦋 Changeset detected

Latest commit: 2bb83c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:01pm

libertymayc
libertymayc commented Mar 19, 2024
View reviewed changes
packages/theme/json/theme.json Outdated
"opacity": "{foundations.opacity.opacity-8}"
},
"color-white-8a": {
"$value": "#ffffff00",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure where opacity stands in theme 2.0, if we would link to an opacity foundation here, and have color and opacity as separate values like the JSON structure for theme 1 fade tokens @origami-z

libertymayc
libertymayc commented Mar 19, 2024
View reviewed changes
packages/theme/json/parsers/validate.js
}
}

function validate() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@origami-z this should check all paths are correct refs

@libertymayc
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320173647
yarn add @salt-ds/lab@0.0.0-snapshot-20240320173647
yarn add @salt-ds/theme@0.0.0-snapshot-20240320173647

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited

Storybook Preview Link https://c21ee998.saltdesignsystem-storybook.pages.dev

@libertymayc libertymayc changed the base branch from theme-json to main March 20, 2024 19:47
@libertymayc
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320194833
yarn add @salt-ds/lab@0.0.0-snapshot-20240320194833
yarn add @salt-ds/theme@0.0.0-snapshot-20240320194833

@libertymayc
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240320195607
yarn add @salt-ds/lab@0.0.0-snapshot-20240320195607
yarn add @salt-ds/theme@0.0.0-snapshot-20240320195607

@libertymayc
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240422144812
yarn add @salt-ds/theme@0.0.0-snapshot-20240422144812

@libertymayc libertymayc mentioned this pull request May 17, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240517153906
yarn add @salt-ds/lab@0.0.0-snapshot-20240517153906
yarn add @salt-ds/theme@0.0.0-snapshot-20240517153906

@libertymayc
change to only include -next files from characteristics and palette d…
2bb83c3 
…irs. foundations only override if -next file is provided
@libertymayc
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @libertymayc! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/core@0.0.0-snapshot-20240517155318
yarn add @salt-ds/lab@0.0.0-snapshot-20240517155318
yarn add @salt-ds/theme@0.0.0-snapshot-20240517155318

@origami-z origami-z force-pushed the unified-color-palette branch 3 times, most recently from f260109 to 09d4ce5 Compare May 22, 2024 15:51
Base automatically changed from unified-color-palette to main May 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@origami-z origami-z Awaiting requested review from origami-z

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@libertymayc @origami-z