Improve the logic of isNode(). (#421)

josdejong · Dec 22, 2023 · 6417eaf · 6417eaf
1 parent f37cc7b
commit 6417eaf
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/environment.js b/src/environment.js
@@ -1,10 +1,12 @@
 
 // source: https://github.com/flexdinesh/browser-or-node
+// source: https://github.com/mozilla/pdf.js/blob/7ea0e40e588864cd938d1836ec61f1928d3877d3/src/shared/util.js#L24
 var isNode = function (nodeProcess) {
   return (
     typeof nodeProcess !== 'undefined' &&
     nodeProcess.versions != null &&
-    nodeProcess.versions.node != null
+    nodeProcess.versions.node != null &&
+    nodeProcess + '' === '[object process]'
   );
 }
 module.exports.isNode = isNode

diff --git a/test/environment.test.js b/test/environment.test.js
@@ -8,10 +8,11 @@ describe('Environment Detection', function () {
     assert.strictEqual(isNode(undefined), false)
     assert.strictEqual(isNode({}), false)
     assert.strictEqual(isNode({ versions: {} }), false)
+    assert.strictEqual(isNode({ versions: { node: '10.0.0' } }), false)
   })
 
   it('is platform assigned to be node', function () {
-    assert.strictEqual(isNode({ versions: { node: '10.0.0' } }), true)
+    assert.strictEqual(isNode(process), true)
   })
 })