Suggest minor changes to the code of Semeru related PR #2
Conversation
| core.endGroup(); | ||
| } | ||
|
|
||
| return availableVersions; | ||
| } | ||
|
|
||
| private getPlatformOption(): string { | ||
| // Adoptium has own platform names so need to map them | ||
| // Adopt has own platform names so need to map them |
There was a problem hiding this comment.
Eclipse Adoptium is the proper project name to use here. There's another similar change that also should be reverted.
There was a problem hiding this comment.
Adoptium was changed here to Adopt mainly for clarity and separation between the old API https://api.adoptopenjdk.net/q/swagger-ui/ and the new one https://api.adoptium.net/q/swagger-ui/ . As Semeru releases are requested using the old API and this API is documented decently, I think it's better to hint the user with Adopt rather than with Adoptium which can lead to the new API docs. Am I wrong here?
There was a problem hiding this comment.
Ok, I understand your reasoning now, though I don't think the platform names are any different between Adoptium and AdoptOpenJDK and anyone who knows about Adoptium (to the degree they know about its APIs :) ) is probably at least a little familiar with its heritage as AdoptOpenJDK. In any case, it's just a suggestion lobbed in from afar ;) .
Description:
In scope of this PR, I'm suggesting to add several changes to the code from PR. These changes are pretty minor and mostly cosmetic.