Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Respin] remove default indent #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lewiscowles1986
Copy link

@Lewiscowles1986 Lewiscowles1986 commented Jul 22, 2023

This is my attempt to re-offer the removal of default indent.

Because it bumps the package version to 2.x, it should protect folks using package.json in a normal way, which I'd define as exact dependencies, or tilde prefixed, so that patches can be applied, but not major versions.

I Also added a note on how to overcome the breaking change if that is the desire.

I Felt bad for making a comment that got someone else work removed without discussion. The first commit is their patch applied to the latest master.

I Couldn't get that verb cli working so I merely applied some markdown changes to the repo.

Changes:

  • re-applied patch to master (ran npm test)
  • bump version
  • improve documentation

@ryanhiebert
Copy link

@Lewiscowles1986 I appreciate the contentiousness about removing another persons work that drove you to make this PR. I have no particular knowledge of this package, but I wanted to give you some deserved Kudos.

@doowb
Copy link
Collaborator

doowb commented Jul 25, 2023

Thanks @Lewiscowles1986 ! I'll get this merged in soon.
I'd also like to do a couple of other breaking changes, so this will be released along with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants