Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to match clap dependency #301

Closed
wants to merge 1 commit into from

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Aug 25, 2023

Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70
This PR:

  • bumps inferno's MSRV to 1.70
  • makes use of a new stdlib API in 1.70 to drop the is-terminal and rustix dependencies.
    • This was also cargo's motivation for bumping MSRV which is how I noticed we could do the same here.

@rukai rukai force-pushed the bump_msrv_to_match_clap_dep branch from c2be034 to 8af0614 Compare August 25, 2023 02:39
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (5d88bc3) to head (8af0614).
Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          19       19           
  Lines        4385     4385           
=======================================
  Hits         3991     3991           
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! While I appreciate the PR, I don't think I want to bump inferno's MSRV to 1.70 yet — it is too new for the time being. And I don't think dropping the is-terminal dependency is that valuable in reality. The fact that clap 4.4 no longer supports 1.64 doesn't actually preclude anyone from building inferno with 1.64, as long as they come up with the right lockfile (which, while annoying, is at least possible). If we land these changes, then users of inferno have to use a newer Rust, or pin an older version of inferno.

I haven't formally set an MSRV policy for this crate, but in general I'd be looking at 12-18 months probably.

@rukai
Copy link
Contributor Author

rukai commented Aug 25, 2023

Understandable, I'll mark this as draft so it's around when it's needed.

@rukai rukai marked this pull request as draft August 25, 2023 21:16
@jonhoo
Copy link
Owner

jonhoo commented Nov 19, 2024

Given I'm about to do a breaking release anyway in #335, I'll land this as part of it! May have to do some cherry-picking, but hey, it did end up useful in the end :D

jonhoo added a commit that referenced this pull request Nov 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Cherry-picks #301
jonhoo added a commit that referenced this pull request Nov 19, 2024
Cherry-picks #301
@jonhoo
Copy link
Owner

jonhoo commented Nov 19, 2024

Merged in #336

@jonhoo jonhoo closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants