-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to match clap dependency #301
Conversation
c2be034
to
8af0614
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 19 19
Lines 4385 4385
=======================================
Hits 3991 3991
Misses 394 394 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! While I appreciate the PR, I don't think I want to bump inferno's MSRV to 1.70 yet — it is too new for the time being. And I don't think dropping the is-terminal
dependency is that valuable in reality. The fact that clap 4.4
no longer supports 1.64 doesn't actually preclude anyone from building inferno
with 1.64, as long as they come up with the right lockfile (which, while annoying, is at least possible). If we land these changes, then users of inferno
have to use a newer Rust, or pin an older version of inferno.
I haven't formally set an MSRV policy for this crate, but in general I'd be looking at 12-18 months probably.
Understandable, I'll mark this as draft so it's around when it's needed. |
Given I'm about to do a breaking release anyway in #335, I'll land this as part of it! May have to do some cherry-picking, but hey, it did end up useful in the end :D |
Merged in #336 |
Since clap 4.4 bumped its MSRV to 1.70 inferno no longer builds on 1.64 and needs minimum 1.70
This PR: