fix: add support for message output #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: @joelanford |
joelanford
reviewed
Oct 4, 2023
README.md
Outdated
| @@ -40,6 +40,11 @@ Skip automatic caching of go module directories (default: `false`) | |||
|
|
|||
| Returns the type (patch, minor, major) of the sementic version that would be required if producing a release. | |||
|
|
|||
| #### `message` | |||
There was a problem hiding this comment.
nit: can we call this output instead of message? output seems a bit more intuitive, at least to me, because this will have the full output of the go-apidiff command.
joelanford
reviewed
Oct 9, 2023
action.yml
Outdated
| @@ -72,5 +75,12 @@ runs: | |||
| echo "semver-type=minor" >> $GITHUB_OUTPUT | |||
| exit 0 | |||
| fi | |||
| EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64) | |||
There was a problem hiding this comment.
I've never seen this before. Is this a security measure to prevent code injection?
There was a problem hiding this comment.
This is how github recommends to do multiline output
joelanford
reviewed
Oct 9, 2023
action.yml
Outdated
Comment on lines
80
to
84
| { | ||
| echo "output<<$EOF" | ||
| echo "$OUTPUT" | ||
| echo "$EOF" | ||
| } >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Seems like we'll only be setting the output variable if semver-type=major. I think this needs to move up above the semver-type checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #29