Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inspect.signature() instead of inspect.getfullargspec() #1165

Merged
merged 6 commits into from Mar 18, 2021
Merged

Use inspect.signature() instead of inspect.getfullargspec() #1165

merged 6 commits into from Mar 18, 2021

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Mar 15, 2021

Fixes #1164.

@codecov
Copy link

codecov bot commented Mar 15, 2021 •
edited

Codecov Report

Merging #1165 (559e228) into master (5c7c456) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 559e228 differs from pull request most recent head e5623c7. Consider uploading reports for the commit e5623c7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   94.44%   94.48%   +0.04%     
==========================================
  Files          47       47              
  Lines        6964     6997      +33     
==========================================
+ Hits         6577     6611      +34     
+ Misses        387      386       -1
Impacted Files Coverage Δ
joblib/func_inspect.py 92.81% <100.00%> (+0.55%) ⬆️
joblib/test/test_memory.py 98.60% <100.00%> (+0.04%) ⬆️
joblib/pool.py 88.61% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7c456...e5623c7. Read the comment docs.

lesteve
lesteve reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been a while since I looked at this code but this looks good at a first glance, thanks a lot for the PR!

Maybe someone else can have a second look? If nobody has some spare bandwidth I'll try to find more time to look at it in more details!

joblib/func_inspect.py Outdated Show resolved Hide resolved
ogrisel
ogrisel approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the fix. Could you please document the fix in the changelog targeting the next release?

tomMoral
tomMoral approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks neat! thx for the fix.

@lesteve lesteve merged commit 457d2c8 into joblib:master Mar 18, 2021
@lesteve
Copy link
Member

lesteve commented Mar 18, 2021

I added the CHANGES.rst entry and merged, thanks a lot @jwodder!

@yarikoptic
Copy link
Contributor

Thanks @jwodder for the PR and @lesteve for the merge. @lesteve et al, I wonder if a release with the fix is coming any time soon?

@yarikoptic yarikoptic mentioned this pull request May 4, 2021
Open
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 7, 2021
py-joblib: updated to 1.1.0
04c14ac 
Release 1.1.0
Fix byte order inconsistency issue during deserialization using joblib.load in cross-endian environment: the numpy arrays are now always loaded to use the system byte order, independently of the byte order of the system that serialized the pickle. joblib/joblib#1181
Fix joblib.Memory bug with the ignore parameter when the cached function is a decorated function. joblib/joblib#1165
Fix joblib.Memory to properly handle caching for functions defined interactively in a IPython session or in Jupyter notebook cell. joblib/joblib#1214
Update vendored loky (from version 2.9 to 3.0) and cloudpickle (from version 1.6 to 2.0) joblib/joblib#1218
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 14, 2021
py-joblib: updated to 1.1.0
37df902 
Release 1.1.0
Fix byte order inconsistency issue during deserialization using joblib.load in cross-endian environment: the numpy arrays are now always loaded to use the system byte order, independently of the byte order of the system that serialized the pickle. joblib/joblib#1181
Fix joblib.Memory bug with the ignore parameter when the cached function is a decorated function. joblib/joblib#1165
Fix joblib.Memory to properly handle caching for functions defined interactively in a IPython session or in Jupyter notebook cell. joblib/joblib#1214
Update vendored loky (from version 2.9 to 3.0) and cloudpickle (from version 1.6 to 2.0) joblib/joblib#1218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

@ogrisel ogrisel ogrisel approved these changes

@tomMoral tomMoral tomMoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use inspect.signature() instead of inspect.getfullargspec()
5 participants
@jwodder @lesteve @yarikoptic @ogrisel @tomMoral