Return early from LineReaderImpl.doList if no possibilities or rows (fixes #941) #942
Conversation
VerKWer
changed the title
|
This is my attempt at fixing issue #941. Unfortunately, I don't have very deep knowledge about the workings of JLine and it might be completely wrong what I'm doing here. It does seem to fix the issue in my projects and it makes sense to me that if there are no possibilities to list (or no space to list them), we should bail out early. Still, any additional input is greatly appreciated. |
When running inside a detached Docker container, calling LineReaderImpl.redisplay resulted in a StackOverflowError. The reason for this is that redisplay eventually calls doList, which again calls redisplay because the size.getRows() is 0.
|
Thx, I think there are two more |
|
Indeed, I saw those but wasn't sure about replacing them because they are inside a lambda, which I believe only executes later. I'm not sure about the details here but since the terminal size can change, I figured it makes more sense to re-read it when |
Calling
LineReaderImpl.redisplaywhen running in a container started via compose can trigger infinite recursion, eventually throwing aStackOverflowError.