Fix vulnerability by updating mkdirp #855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a prototype pollution vulnerability in minimist 0.0.8, used by mkdirp 0.5.1. https://www.npmjs.com/advisories/1179 As the only thing we use from mkdirp is `mkdirp.sync`, and it is still seen in the latest mkdirp, I think it is safe to update mkdirp without breaking anything.
|
I see this error |
|
As per isaacs/node-mkdirp#7 (comment) instead of 1.0.3 we can safely update to 0.5.3. I did a separate PR #857 just to speed up this process, but got an error on test-types CI check 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
There is a prototype pollution vulnerability in minimist 0.0.8, used by mkdirp 0.5.1.
https://www.npmjs.com/advisories/1179
I suggest updating mkdirp to ^1.0.3, the latest version, which does not depend on minimist at all.
What else might be affected
As the only thing we use from mkdirp is
mkdirp.sync, and it is still seen in the latest mkdirp, I think it is safe to update mkdirp without breaking anything.Tasks
jimp.d.ts