Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup new triage labeling #8800

Conversation

renanfranca
Copy link
Collaborator

@murdos
Copy link
Collaborator

murdos commented Jan 31, 2024

Previous workflow was not adding triage label if there were already some labels: does it work the same way?

@renanfranca renanfranca force-pushed the 8528-setup-new-labeling-github-action branch from dde4fd1 to b514e7a Compare January 31, 2024 16:05
@renanfranca renanfranca marked this pull request as ready for review January 31, 2024 16:06
@renanfranca
Copy link
Collaborator Author

Previous workflow was not adding triage label if there were already some labels: does it work the same way?

I have to study the configuration options with regular expressions. Today it applies if there are some labels: renanfranca/test-issue-label-github-action#9
image

By the way, thanks for approving the pull request (github/issue-labeler#82), that was unexpected! Cool! 😎 Do you have write access there too?

@pascalgrimaud
Copy link
Member

Yes the rules are:

  • if no label, add triage
  • if existing label, do nothing

@pascalgrimaud
Copy link
Member

@renanfranca : everyone can approved pull request, you don't need to have permission

@renanfranca renanfranca force-pushed the 8528-setup-new-labeling-github-action branch from b514e7a to 8d26764 Compare February 1, 2024 12:18
@renanfranca renanfranca force-pushed the 8528-setup-new-labeling-github-action branch from 8d26764 to 9a6eff6 Compare February 1, 2024 12:19
@renanfranca
Copy link
Collaborator Author

renanfranca commented Feb 1, 2024

I prefer to add one more step to check if there are any labels rather than implement the changes inside the github-action issue-labeler itself. I think issue-labeler is better generic than specialized in everyone's needs.

It is working for issues:

It is working for pull requests:

@pascalgrimaud pascalgrimaud merged commit 5b44cf6 into jhipster:main Feb 1, 2024
12 checks passed
@pascalgrimaud
Copy link
Member

Totally agree. It's specific to here, that's why the code belong to this repo
Thanks @renanfranca for your work

@renanfranca
Copy link
Collaborator Author

@pascalgrimaud : You are welcome! 😃👍

@renanfranca renanfranca deleted the 8528-setup-new-labeling-github-action branch February 1, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants